Attachment 343746 Details for Bug 187111 – Patch

[patch] Patch

bug-187111-20180627212123.patch (text/plain), 2.17 KB, created by Charlie Turner on 2018-06-27 13:21:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2018-06-27 13:21:24 PDT

Size: 2.17 KB

patch

obsolete

>Subversion Revision: 233198
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 42d33ee911bc53a4a0a8da29356b6f5f1790d338..023302061f2d0ea19a1a93d64ee09a1f60451ac3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,24 @@
>+2018-06-27  Charlie Turner  <cturner@igalia.com>
>+
>+        [GStreamer] Return a valid time values in unprerolled states
>+        https://bugs.webkit.org/show_bug.cgi?id=187111
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        After r230584 in bug 180253, asserts were added in
>+        PlatformTimeRanges::add to check that both ends of the range were
>+        valid times. In the non-MSE GStreamer player, this assert was
>+        firing on https://www.w3.org/2010/05/video/mediaevents.html due to
>+        seekable being called in nonprerolled states. In this case
>+        MediaPlayerPrivateInterface::seekable was calling GStreamer's
>+        maxTimeSeekable, which calls in durationMediaTime. The guard
>+        against calling gst_element_query_duration when not prerolled was
>+        returning a different time value than when the duration query
>+        itself failed. Hence the assert firing.
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::durationMediaTime const):
>+
> 2018-06-25  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Computed height for in-flow non-replaced should not include padding and border.
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index fad673e54065b878a837e148be5ca508df1f66f7..97ff0532e91c5640772afa483fa0b7df9af156ad 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -464,7 +464,7 @@ MediaTime MediaPlayerPrivateGStreamer::durationMediaTime() const
> 
>     // The duration query would fail on a not-prerolled pipeline.
>     if (GST_STATE(m_pipeline.get()) < GST_STATE_PAUSED)
>-        return MediaTime::invalidTime();
>+        return MediaTime::positiveInfiniteTime();
> 
>     gint64 timeLength = 0;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 187111: 343746 | 344570 | 344571 | 344574 | 345344