Attachment 343721 Details for Bug 185796 – Rebased

[patch] Rebased

bug-185796-20180627113234.patch (text/plain), 3.90 KB, created by Andy VanWagoner on 2018-06-27 10:32:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Andy VanWagoner

Created: 2018-06-27 10:32:34 PDT

Size: 3.90 KB

patch

obsolete

>Subversion Revision: 233262
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 9483c9684a134d0b245475bcbccb226fdb30b501..890928fb7efb1d9e4eb7a6779835ef651431e066 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-27  Andy VanWagoner  <andy@vanwagoner.family>
>+
>+        [INTL] Call Typed Array elements toLocaleString with locale and options
>+        https://bugs.webkit.org/show_bug.cgi?id=185796
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Improve ECMA 402 compliance of typed array toLocaleString, passing along
>+        the locale and options to element toLocaleString calls.
>+
>+        * builtins/TypedArrayPrototype.js:
>+        (toLocaleString):
>+
> 2018-06-27  Mark Lam  <mark.lam@apple.com>
> 
>         DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties.
>diff --git a/Source/JavaScriptCore/builtins/TypedArrayPrototype.js b/Source/JavaScriptCore/builtins/TypedArrayPrototype.js
>index 66dd6451591e23c28f56fb6b000337f75e290725..989aa606414e647e34cf46d24fffabb480423ead 100644
>--- a/Source/JavaScriptCore/builtins/TypedArrayPrototype.js
>+++ b/Source/JavaScriptCore/builtins/TypedArrayPrototype.js
>@@ -396,7 +396,7 @@ function filter(callback /*, thisArg */)
>     return result;
> }
> 
>-function toLocaleString()
>+function toLocaleString(/* locale, options */)
> {
>     "use strict";
> 
>@@ -405,9 +405,9 @@ function toLocaleString()
>     if (length == 0)
>         return "";
> 
>-    var string = this[0].toLocaleString();
>+    var string = this[0].toLocaleString(@argument(0), @argument(1));
>     for (var i = 1; i < length; i++)
>-        string += "," + this[i].toLocaleString();
>+        string += "," + this[i].toLocaleString(@argument(0), @argument(1));
> 
>     return string;
> }
>diff --git a/JSTests/ChangeLog b/JSTests/ChangeLog
>index f21328620ccf574a43e06bdcc1f758cf3680d8b1..b1dbcd6e850724f4b050f9b64bc60faafcb3c732 100644
>--- a/JSTests/ChangeLog
>+++ b/JSTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-27  Andy VanWagoner  <andy@vanwagoner.family>
>+
>+        [INTL] Call Typed Array elements toLocaleString with locale and options
>+        https://bugs.webkit.org/show_bug.cgi?id=185796
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove now passing TypedArray toLocaleString expectation.
>+
>+        * test262/expectations.yaml:
>+
> 2018-06-27  Mark Lam  <mark.lam@apple.com>
> 
>         DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties.
>diff --git a/JSTests/test262/expectations.yaml b/JSTests/test262/expectations.yaml
>index afa42de7932ed02f0967d175174e07b0dbb770f9..24e9351d4c3172a79af5406d7fea82316d6de297 100644
>--- a/JSTests/test262/expectations.yaml
>+++ b/JSTests/test262/expectations.yaml
>@@ -1825,9 +1825,6 @@ test/intl402/PluralRules/length.js:
> test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js:
>   default: 'Test262Error: Should have different arrays Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«undefinedÃÂ») to be false'
>   strict mode: 'Test262Error: Should have different arrays Expected SameValue(ÃÂ«undefinedÃÂ», ÃÂ«undefinedÃÂ») to be false'
>-test/intl402/TypedArray/prototype/toLocaleString/calls-toLocaleString-number-elements.js:
>-  default: 'Test262Error: Expected SameValue(ÃÂ«0ÃÂ», ÃÂ«Ã Â¹Â.Ã Â¹ÂÃ Â¹ÂÃ Â¹ÂÃÂ») to be true (Testing with Float64Array.)'
>-  strict mode: 'Test262Error: Expected SameValue(ÃÂ«0ÃÂ», ÃÂ«Ã Â¹Â.Ã Â¹ÂÃ Â¹ÂÃ Â¹ÂÃÂ») to be true (Testing with Float64Array.)'
> test/intl402/fallback-locales-are-supported.js:
>   default: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-CN isn't. Expected SameValue(ÃÂ«-1ÃÂ», ÃÂ«-1ÃÂ») to be false (Testing with NumberFormat.)"
>   strict mode: "Test262Error: Locale zh-Hans-CN is supported, but fallback zh-CN isn't. Expected SameValue(ÃÂ«-1ÃÂ», ÃÂ«-1ÃÂ») to be false (Testing with NumberFormat.)"

Actions: View | Formatted Diff | Diff

Attachments on bug 185796: 340768 | 343721 | 345765