WebKit Bugzilla
Attachment 343699 Details for
Bug 187087
: [GStreamer] Coverity scan issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187087-20180627094205.patch (text/plain), 2.98 KB, created by
Tomas Popela
on 2018-06-27 00:42:06 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tomas Popela
Created:
2018-06-27 00:42:06 PDT
Size:
2.98 KB
patch
obsolete
>Subversion Revision: 233246 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index d14476f37f595cb8edaff91c7323e8a6d48be31a..737997bb62decb110c9d7734d0ae583e06cb9ace 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-06-27 Tomas Popela <tpopela@redhat.com> >+ >+ [GStreamer] Coverity scan issues >+ https://bugs.webkit.org/show_bug.cgi?id=187087 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fix uninitialized members. >+ >+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: >+ * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: >+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: >+ > 2018-06-26 Yusuke Suzuki <utatane.tea@gmail.com> > > [JSC] Pass VM& to functions more >diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp >index a622eb28a4eb65f05ea4d02534f3f78fd0dc865d..b61471bcb3d1c8a272c2ecc6869aab53973dbaf4 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp >+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp >@@ -267,10 +267,10 @@ public: > > private: > GstBuffer* m_buffer; >- GstVideoFrame m_videoFrame; >+ GstVideoFrame m_videoFrame { }; > IntSize m_size; > bool m_hasAlphaChannel; >- TextureMapperGL::Flags m_flags; >+ TextureMapperGL::Flags m_flags { }; > GLuint m_textureID { 0 }; > bool m_isMapped { false }; > }; >diff --git a/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp >index 164e7a4054852832aad3f182c98ae49fb32d12c9..c893b473b3310ee5020717b182073c5510af51dc 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp >+++ b/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp >@@ -134,7 +134,7 @@ struct _WebKitVideoSinkPrivate { > > VideoRenderRequestScheduler scheduler; > GstVideoInfo info; >- GstCaps* currentCaps; >+ GstCaps* currentCaps { nullptr }; > }; > > #define webkit_video_sink_parent_class parent_class >diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >index eb46902485f0c4135d76e3325988bb5677511073..b07c2b02718ab8957b26f1b77e2b0a6b841d4998 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >+++ b/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h >@@ -86,7 +86,7 @@ private: > MediaSourceGStreamer* m_mediaSource; > ContentType m_type; > Ref<MediaSourceClientGStreamerMSE> m_client; >- SourceBufferPrivateClient* m_sourceBufferPrivateClient; >+ SourceBufferPrivateClient* m_sourceBufferPrivateClient { nullptr }; > bool m_isReadyForMoreSamples = true; > bool m_notifyWhenReadyForMoreSamples = false; > AtomicString m_trackId;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187087
: 343699