Attachment 343682 Details for Bug 187079 – Patch

[patch] Patch

bug-187079-20180626203556.patch (text/plain), 1.75 KB, created by Jeremy Jones on 2018-06-26 20:35:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-06-26 20:35:56 PDT

Size: 1.75 KB

patch

obsolete

>Subversion Revision: 233214
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 766381d2e378d311a118d0724b7016db11b8eabc..14ad58360e14c6cba1fb29fafc7e35c1a13ef284 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-26  Jeremy Jones  <jeremyj@apple.com>
>+
>+        Fullscreen exits when placeholder is removed then added during a single runloop.
>+        https://bugs.webkit.org/show_bug.cgi?id=187079
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Instead of closing fullscreen as soon as the placeholder is removed from the view hierarchy,
>+        give the placeholder until the next runloop to be re-added to the view hierarchy.
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
>+        (-[WKFullScreenWindowController placeholderWillMoveToSuperview:]):
>+
> 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
> 
>         [Mac] AirPlay picker uses incorrect theme in Dark mode
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>index d2590f1ba5492e1466c9c4069740562c48a02162..ab84d8355e04867c3a6fa155ad109028374a3489 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm
>@@ -753,8 +753,13 @@ - (void)videoControlsManagerDidChange
> 
> - (void)placeholderWillMoveToSuperview:(UIView *)superview
> {
>-    if (!superview)
>-        [self close];
>+    if (superview)
>+        return;
>+
>+    dispatch_async(dispatch_get_main_queue(), ^{
>+        if ([_webViewPlaceholder superview] == nil && [_webViewPlaceholder parent] == self)
>+            [self close];
>+    });
> }
> 
> #pragma mark -

Actions: View | Formatted Diff | Diff

Attachments on bug 187079: 343682