Attachment 343679 Details for Bug 187078 – Patch

[patch] Patch

bug-187078-20180627113706.patch (text/plain), 2.32 KB, created by Yusuke Suzuki on 2018-06-26 19:37:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-06-26 19:37:07 PDT

Size: 2.32 KB

patch

obsolete

>Subversion Revision: 233240
>diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog
>index b920f4398eb78969b8e3b45f0da53b96159343e5..036ff79a1aa6c861b8dcfe55ca42726b9fbd5bf1 100644
>--- a/Source/ThirdParty/libwebrtc/ChangeLog
>+++ b/Source/ThirdParty/libwebrtc/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [GTK][WPE] Remove gflags from libwebrtc build
>+        https://bugs.webkit.org/show_bug.cgi?id=187078
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        gflags is used only in libyuv unit tests. So the Apple ports do not build & link it.
>+        GTK and WPE can do the same thing: not building gflags. By doing so, we can achieve
>+        the following results.
>+
>+        1. Remove static initializers defined for gflags.
>+        2. Reduce binary size.
>+
>+        * CMakeLists.txt:
>+
> 2018-06-25  Keith Rollin  <krollin@apple.com>
> 
>         Adjust webrtc library for LTO
>diff --git a/Source/ThirdParty/libwebrtc/CMakeLists.txt b/Source/ThirdParty/libwebrtc/CMakeLists.txt
>index 11037cb46ceb707c43e6b13b3fbd087eef29e624..c4a662f91772b2902c0b0b6c376e10fa0bf5c430 100644
>--- a/Source/ThirdParty/libwebrtc/CMakeLists.txt
>+++ b/Source/ThirdParty/libwebrtc/CMakeLists.txt
>@@ -1373,7 +1373,6 @@ set(webrtc_SOURCES
>     Source/webrtc/voice_engine/channel_proxy.cc
>     Source/webrtc/voice_engine/transport_feedback_packet_loss_tracker.cc
>     Source/webrtc/voice_engine/utility.cc
>-    $<TARGET_OBJECTS:gflags>
>     $<TARGET_OBJECTS:libsrtp>
> )
> 
>@@ -1462,30 +1461,6 @@ target_link_libraries(webrtc ${VPX_LIBRARY})
> 
> target_link_libraries(webrtc ${EVENT_LIBRARY})
> 
>-# gflags package compilation
>-set(gflags_SOURCES
>-    Source/third_party/gflags/src/src/gflags.cc
>-    Source/third_party/gflags/src/src/gflags_completions.cc
>-    Source/third_party/gflags/src/src/gflags_reporting.cc
>-)
>-
>-add_library(gflags OBJECT ${gflags_SOURCES})
>-
>-target_compile_options(gflags PRIVATE
>-    "-w"
>-)
>-
>-target_compile_definitions(gflags PRIVATE
>-    GFLAGS_DLL_DECL=
>-    GFLAGS_DLL_DECLARE_FLAG=
>-    GFLAGS_DLL_DEFINE_FLAG=
>-)
>-
>-target_include_directories(gflags PRIVATE
>-    Source/third_party/gflags/gen/posix/include/gflags/
>-    Source/third_party/gflags/gen/posix/include/private/
>-)
>-
> # libsrtp package compilation
> set(libsrtp_SOURCES
>     Source/third_party/libsrtp/crypto/cipher/aes_gcm_ossl.c

Flags:

alex: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187078: 343679