Attachment 343677 Details for Bug 187077 – Patch

[patch] Patch

bug-187077-20180626192736.patch (text/plain), 2.20 KB, created by Tim Horton on 2018-06-26 19:27:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2018-06-26 19:27:36 PDT

Size: 2.20 KB

patch

obsolete

>Subversion Revision: 233218
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 17e323e34c720ea0b74546c08d7a88327ebe8467..d98b38a7a212a03a1d0dc69bf6a23989f26f6f66 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-26  Tim Horton  <timothy_horton@apple.com>
>+
>+        When trying to print a very long email on iOS, the print preview is blank
>+        https://bugs.webkit.org/show_bug.cgi?id=187077
>+        <rdar://problem/41107013>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/WebPageProxyIOS.mm:
>+        (WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
>+        ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,
>+        (as opposed to Connection::sendSync's default timeout of â seconds).
>+        The printing path already waits â seconds for the final PDF, but currently
>+        uses the default 1 second timeout for page count computation. If page
>+        count computation takes more than 1 second, the preview will be blank.
>+        Since the print preview is generated asynchronously, we really want
>+        to wait until it's done, and not give up after 1 second.
>+
> 2018-06-26  Timothy Horton  <timothy_horton@apple.com>
> 
>         Rearrange some WebPreferences; move two non-experimental prefs out of the experimental section
>diff --git a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>index f31515cbe8e4fd420675061c717ada3ae6983e12..7a704c1ff6ead681e9af31ff3a1093faa8d0d722 100644
>--- a/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
>@@ -1028,7 +1028,7 @@ uint32_t WebPageProxy::computePagesForPrintingAndDrawToPDF(uint64_t frameID, con
>     uint32_t pageCount = 0;
>     auto callbackID = m_callbacks.put(WTFMove(callback), m_process->throttler().backgroundActivityToken());
>     using Message = Messages::WebPage::ComputePagesForPrintingAndDrawToPDF;
>-    process().sendSync(Message(frameID, printInfo, callbackID), Message::Reply(pageCount), m_pageID);
>+    process().sendSync(Message(frameID, printInfo, callbackID), Message::Reply(pageCount), m_pageID, Seconds::infinity());
>     return pageCount;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 187077: 343677