Attachment 343668 Details for Bug 187018 – Patch

[patch] Patch

bug-187018-20180626181015.patch (text/plain), 4.42 KB, created by youenn fablet on 2018-06-26 18:10:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-06-26 18:10:15 PDT

Size: 4.42 KB

patch

obsolete

>Subversion Revision: 233216
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 0f4a8bbe845e7339f0c0d99a720e54da2a4d3cd1..6179469589dd1e64b86e9e12b1a2b44892de552c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-26  Youenn Fablet  <youenn@apple.com>
>+
>+        Update Cisco Webex sandbox to make it functional
>+        https://bugs.webkit.org/show_bug.cgi?id=187018
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These cisco sandbox changes allow removing sandbox errors and makes the plug-in almost functional modulo quarantine of downloaded files.
>+
>+        * Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb:
>+
> 2018-06-26  Youenn Fablet  <youenn@apple.com>
> 
>         Remove quarantine for Webex plugin
>diff --git a/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb b/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>index ca6cf8358fac8adcf8dcbdd3a454990a850739d7..9ecdaf0298ef0cabc3ee5736069c26fd6b01f483 100644
>--- a/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>+++ b/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>@@ -28,6 +28,20 @@
> (define (home-literal home-relative-literal)
>     (literal (string-append (param "HOME_DIR") home-relative-literal)))
> 
>+(allow file-issue-extension
>+    (require-any
>+        (extension-class "com.apple.app-sandbox.read")
>+        (extension-class "com.apple.app-sandbox.read-write")))
>+
>+(allow file-read* file-write*
>+    (subpath "/Library/ScriptingAdditions"))
>+
>+(allow file-read* file-write*
>+    (home-subpath "/Library/Saved Application State/com.webex.meetingmanager.savedState"))
>+
>+(allow file-read* file-write*
>+    (home-subpath "/Library/Caches/com.webex.meetingmanager"))
>+
> (allow file-read* file-write*
>     (home-literal "/Library/Preferences/com.cisco.webex.fuzzyWindowConfig.plist"))
> 
>@@ -37,40 +51,49 @@
> (allow file-read* file-write* file-write-create
>     (home-subpath "/Library/Application Support/WebEx Folder"))
> 
>+(allow file-read*
>+    (home-literal "/Library/Preferences/com.apple.AppleMultitouchTrackpad.plist"))
>+
>+(allow file-read-data
>+    (home-literal "/Library/Preferences/com.apple.LaunchServices/com.apple.launchservices.secure.plist"))
>+
> ;; FIXME: We should tigthen the sandbox to some tmp subfolders
> (allow file*
>     (prefix "/private/tmp"))
> 
>+(allow file*
>+    (prefix "/private/var/folders"))
>+
> (allow file-read-data file-write-data
>     (path "/dev/tty"))
> 
>+(allow distributed-notification-post)
> (allow process-exec)
> (allow process-fork)
>-(allow distributed-notification-post)
>+(allow signal)
> 
> (allow mach-lookup
>     (global-name "com.apple.PerformanceAnalysis.animationperfd")
>+    (global-name "com.apple.airportd")
>+    (global-name "com.apple.audio.SystemSoundServer-OSX")
>+    (global-name "com.apple.cmio.registerassistantservice")
>+    (global-name "com.apple.coreservices.quarantine-resolver")
>+    (global-name "com.apple.coreservices.sharedfilelistd.xpc")
>+    (global-name "com.apple.dockling.server")
>     (global-name "com.apple.dock.fullscreen")
>-    (global-name "com.apple.quicklook.ui.helper.active")
>-    (global-name "com.apple.quicklook.ui.helper")
>     (global-name "com.apple.inputmethodkit.launchagent")
>     (global-name "com.apple.inputmethodkit.launcher")
>-    (global-name "com.apple.inputmethodkit.getxpcendpoint"))
>-
>-(allow iokit-get-properties
>-    (iokit-property "PowerControlSupported")
>-    (iokit-property "SupportTapToWake")
>-    (iokit-property "ResetOnLockMs")
>-    (iokit-property "ResetOnUnlockMs")
>-    (iokit-property "ShouldResetOnButton")
>-    (iokit-property "WirelessChargingNotificationSupported")
>-    (iokit-property "SupportsSilentClick")
>-    (iokit-property "MinDigitizerPressureValue")
>-    (iokit-property "AccurateMaxDigitizerPressureValue")
>-    (iokit-property "ExtendedMaxDigitizerPressureValue")
>-    (iokit-property "AnimationThresholds")
>-    (iokit-property "ActivationThresholds")
>-    (iokit-property "mt-device-id"))
>+    (global-name "com.apple.inputmethodkit.getxpcendpoint")
>+    (global-name "com.apple.iohideventsystem")
>+    (global-name "com.apple.lsd.modifydb")
>+    (global-name "com.apple.quicklook.ui.helper.active")
>+    (global-name "com.apple.quicklook.ui.helper")
>+    (global-name "com.apple.tccd"))
>+
>+(allow iokit-open
>+    (iokit-user-client-class "IOHIDLibUserClient"))
>+
>+(allow iokit-get-properties)
> 
> (webkit-powerbox)
> (webkit-printing)

Actions: View | Formatted Diff | Diff

Attachments on bug 187018: 343543 | 343586 | 343668 | 343696 | 343711 | 343730