Attachment 343660 Details for Bug 187070 – proposed patch.

[patch] proposed patch.

bug-187070.patch (text/plain), 1.57 KB, created by Mark Lam on 2018-06-26 16:41:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-06-26 16:41:52 PDT

Size: 1.57 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 233227)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-06-26  Mark Lam  <mark.lam@apple.com>
>+
>+        Skip some unnecessary work in Interpreter::getStackTrace().
>+        https://bugs.webkit.org/show_bug.cgi?id=187070
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * interpreter/Interpreter.cpp:
>+        (JSC::Interpreter::getStackTrace):
>+
> 2018-06-26  Mark Lam  <mark.lam@apple.com>
> 
>         ASSERTION FAILED: length > butterfly->vectorLength() in JSObject::ensureLengthSlow().
>Index: Source/JavaScriptCore/interpreter/Interpreter.cpp
>===================================================================
>--- Source/JavaScriptCore/interpreter/Interpreter.cpp	(revision 233227)
>+++ Source/JavaScriptCore/interpreter/Interpreter.cpp	(working copy)
>@@ -556,13 +556,15 @@ void Interpreter::getStackTrace(JSCell* 
>     DisallowGC disallowGC;
>     VM& vm = m_vm;
>     CallFrame* callFrame = vm.topCallFrame;
>-    if (!callFrame)
>+    if (!callFrame || !maxStackSize)
>         return;
> 
>     size_t framesCount = 0;
>+    size_t maxFramesCountNeeded = maxStackSize + framesToSkip;
>     StackVisitor::visit(callFrame, &vm, [&] (StackVisitor&) -> StackVisitor::Status {
>-        framesCount++;
>-        return StackVisitor::Continue;
>+        if (++framesCount < maxFramesCountNeeded)
>+            return StackVisitor::Continue;
>+        return StackVisitor::Done;
>     });
>     if (framesCount <= framesToSkip)
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 187070: 343660