Attachment 343641 Details for Bug 187004 – Patch

[patch] Patch

bug-187004-20180626142956.patch (text/plain), 2.09 KB, created by Aditya Keerthi on 2018-06-26 14:29:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aditya Keerthi

Created: 2018-06-26 14:29:57 PDT

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 232962
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index aadfbc89d1b730a9b6461761ca347eb132ecd99b..be026e3c67ddad29ccb902238123a5f05654ad82 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-25  Aditya Keerthi  <akeerthi@apple.com>
>+
>+        Tap highlight displayed when tapping a field that is already focussed
>+        https://bugs.webkit.org/show_bug.cgi?id=187004
>+        <rdar://problem/41428008>
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In the case where fast-clicking is enabled, _singleTapCommited: could be invoked
>+        before the tap highlight request, causing _potentialTapInProgress to be set to NO.
>+        This results in the early return for preventing multiple tap highlights on an
>+        assisted node to be skipped. Since a tap highlight should never be shown for an
>+        input field that is already focussed, _potentialTapInProgress can be removed from
>+        the early return condition.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
>+
> 2018-06-19  Brent Fulgham  <bfulgham@apple.com>
> 
>         MAP_JIT is not present for minimal simulator builds
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 9246146b4df86356f21cf2dd6acc334896137342..eebe0e9755e2d98c836f71e0af9285e650acf13a 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1175,7 +1175,7 @@ static NSValue *nsSizeForTapHighlightBorderRadius(WebCore::IntSize borderRadius,
>     if (!_isTapHighlightIDValid || _latestTapID != requestID)
>         return;
> 
>-    if (_potentialTapInProgress && hasAssistedNode(_assistedNodeInformation) && _positionInformation.nodeAtPositionIsAssistedNode)
>+    if (hasAssistedNode(_assistedNodeInformation) && _positionInformation.nodeAtPositionIsAssistedNode)
>         return;
> 
>     _isTapHighlightIDValid = NO;

Actions: View | Formatted Diff | Diff

Attachments on bug 187004: 343509 | 343641