Attachment 343635 Details for Bug 187016 – Patch

[patch] Patch

bug-187016-20180626134014.patch (text/plain), 1.84 KB, created by Chris Dumez on 2018-06-26 13:40:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-26 13:40:15 PDT

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 233216
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f049638b707a069c4acc01e0bc84d470d5043c0c..0470a5e19d8c777a21b69daa0364a365e3c0facb 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-26  Chris Dumez  <cdumez@apple.com>
>+
>+        Simplify NetworkStorageSession::getAllStorageAccessEntries()
>+        https://bugs.webkit.org/show_bug.cgi?id=187016
>+
>+        Reviewed by Youenn Fablet.
>+
>+        Iterate over the HashMaps' values instead of iterating over their keys and then looking them
>+        up in the HashMap.
>+
>+        * platform/network/cf/NetworkStorageSessionCFNet.cpp:
>+        (WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
>+
> 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
> 
>         [Mac] AirPlay picker uses incorrect theme in Dark mode
>diff --git a/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp b/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>index 22746f04417edc93d1d2a12d07526bdb2b31362f..4e3105610c99b9e86f3dab14dd5fcc3c5d31d307 100644
>--- a/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>+++ b/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>@@ -331,10 +331,9 @@ bool NetworkStorageSession::hasStorageAccess(const String& resourceDomain, const
> Vector<String> NetworkStorageSession::getAllStorageAccessEntries() const
> {
>     Vector<String> entries;
>-    for (auto& pageID : m_framesGrantedStorageAccess.keys()) {
>-        auto it1 = m_framesGrantedStorageAccess.find(pageID);
>-        for (auto& frameID : it1->value.keys())
>-            entries.append(it1->value.find(frameID)->value);
>+    for (auto& innerMap : m_framesGrantedStorageAccess.values()) {
>+        for (auto& value : innerMap.values())
>+            entries.append(value);
>     }
>     return entries;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 187016: 343537 | 343578 | 343635