Attachment 343615 Details for Bug 187051 – Patch

[patch] Patch

bug-187051-20180626192818.patch (text/plain), 1.64 KB, created by Carlos Alberto Lopez Perez on 2018-06-26 10:28:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2018-06-26 10:28:20 PDT

Size: 1.64 KB

patch

obsolete

>Subversion Revision: 233203
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 6138c15e7b8113b0089d750513281e5bb65dde6f..f8581cb3eddf6a371f4b1ed0cc6be1f61c151029 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
>+        https://bugs.webkit.org/show_bug.cgi?id=187051
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Revert r233065 changes over UnlinkedCodeBlock.h to allow
>+        clang-3.8 to be able to compile this back (with libstdc++5)
>+
>+        * bytecode/UnlinkedCodeBlock.h:
>+        (JSC::UnlinkedCodeBlock::decompressArrayAllocationProfile):
>+
> 2018-06-25  Saam Barati  <sbarati@apple.com>
> 
>         JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
>diff --git a/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h b/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h
>index 31e5cf1849da4a0af756e2dc62077ef340e5a631..5ae594b37e327d1dc07f1c09021ebf22a9d05143 100644
>--- a/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h
>+++ b/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h
>@@ -309,7 +309,7 @@ public:
>     {
>         unsigned profile = (compressedProfile << 8) >> 8;
>         IndexingType recommendedIndexingType = compressedProfile >> 24;
>-        return { profile, recommendedIndexingType };
>+        return std::make_tuple<unsigned, IndexingType>(WTFMove(profile), WTFMove(recommendedIndexingType));
> 
>     }
>     unsigned numberOfObjectAllocationProfiles() { return m_objectAllocationProfileCount; }

Actions: View | Formatted Diff | Diff

Attachments on bug 187051: 343615