Attachment 343608 Details for Bug 187049 – [GStreamer] Do not forget to set stream on track switching

[patch] [GStreamer] Do not forget to set stream on track switching

GStreamer-Do-not-forget-to-set-stream-on-track-swi.patch (text/plain), 2.15 KB, created by Thibault Saunier on 2018-06-26 09:12:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-06-26 09:12:36 PDT

Size: 2.15 KB

patch

obsolete

>From 2de1f5360bf72702fbd947eafad2b3e0a39f48ff Mon Sep 17 00:00:00 2001
>From: Thibault Saunier <tsaunier@igalia.com>
>Date: Mon, 25 Jun 2018 09:04:01 -0400
>Subject: [PATCH xserver] [GStreamer] Do not forget to set stream on track
> switching
>
>This was an overlooked issue introduced in 186678
>
>https://bugs.webkit.org/show_bug.cgi?id=187049
>---
> Source/WebCore/ChangeLog                           | 14 ++++++++++++++
> .../gstreamer/MediaPlayerPrivateGStreamer.cpp      |  2 +-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6ef15583b01..5b4efd3dcb1 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-26  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GStreamer] Do not forget to set stream on track switching
>+        https://bugs.webkit.org/show_bug.cgi?id=187049
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This was an overlooked issue introduced in Bug #186678
>+
>+        This is already tested, but we currently run only tests against playbin2
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::enableTrack):
>+
> 2018-06-25  David Kilzer  <ddkilzer@apple.com>
> 
>         REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index fad673e5406..1a26013e900 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -740,7 +740,7 @@ void MediaPlayerPrivateGStreamer::enableTrack(TrackPrivateBaseGStreamer::TrackTy
>     GstStream* stream = nullptr;
> 
>     if (!m_isLegacyPlaybin) {
>-        gst_stream_collection_get_stream(m_streamCollection.get(), index);
>+        stream = gst_stream_collection_get_stream(m_streamCollection.get(), index);
>         if (!stream) {
>             GST_WARNING_OBJECT(pipeline(), "No stream to select at index %u", index);
>             return;
>-- 
>2.18.0

Actions: View | Formatted Diff | Diff

Attachments on bug 187049: 343606 | 343608