WebKit Bugzilla
Attachment 343604 Details for
Bug 187047
: Promote some experimental features to traditional features
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187047-20180626083740.patch (text/plain), 8.22 KB, created by
Tim Horton
on 2018-06-26 08:37:41 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tim Horton
Created:
2018-06-26 08:37:41 PDT
Size:
8.22 KB
patch
obsolete
>Subversion Revision: 233189 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index 3c07cd5583b58fa2e25f96de25845356a3333513..6e2fa5500c3c0ba60141249cbf3dbfc3a5db1270 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,18 @@ >+2018-06-26 Tim Horton <timothy_horton@apple.com> >+ >+ Promote some experimental features to traditional features >+ https://bugs.webkit.org/show_bug.cgi?id=187047 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * Shared/WebPreferences.yaml: >+ Reindent. >+ Promote some shipped/default-on features to non-experimental. >+ >+ * WebProcess/Storage/WebSWContextManagerConnection.cpp: >+ (WebKit::WebSWContextManagerConnection::updatePreferencesStore): >+ Remove the Cache API pref, instead making it follow the Service Workers pref. >+ > 2018-06-25 Tim Horton <timothy_horton@apple.com> > > WKThumbnailView fallback background is blindingly bright in Dark Mode >diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml >index 542a45c17a78f97e0454e610ce5308dab3a4c301..f50ac4bde69d5e34fd850bb688ca24dfb6f81d0d 100644 >--- a/Source/WebKit/Shared/WebPreferences.yaml >+++ b/Source/WebKit/Shared/WebPreferences.yaml >@@ -1001,10 +1001,10 @@ TiledScrollingIndicatorVisible: > webcoreName: showTiledScrollingIndicator > > DisableScreenSizeOverride: >- type: bool >- defaultValue: false >- category: debug >- condition: PLATFORM(IOS) >+ type: bool >+ defaultValue: false >+ category: debug >+ condition: PLATFORM(IOS) > > SimpleLineLayoutDebugBordersEnabled: > type: bool >@@ -1056,15 +1056,42 @@ ShouldAllowUserInstalledFonts: > defaultValue: true > > MediaCapabilitiesEnabled: >- type: bool >- defaultValue: false >- webcoreBinding: RuntimeEnabledFeatures >+ type: bool >+ defaultValue: false >+ webcoreBinding: RuntimeEnabledFeatures > > SystemPreviewEnabled: >- type: bool >- defaultValue: false >- webcoreBinding: RuntimeEnabledFeatures >- condition: USE(SYSTEM_PREVIEW) >+ type: bool >+ defaultValue: false >+ webcoreBinding: RuntimeEnabledFeatures >+ condition: USE(SYSTEM_PREVIEW) >+ >+ConstantPropertiesEnabled: >+ type: bool >+ defaultValue: true >+ >+CrossOriginWindowPolicySupportEnabled: >+ type: bool >+ defaultValue: true >+ >+SubresourceIntegrityEnabled: >+ type: bool >+ defaultValue: true >+ >+RestrictedHTTPResponseAccess: >+ type: bool >+ defaultValue: true >+ webcoreBinding: RuntimeEnabledFeatures >+ >+CrossOriginResourcePolicyEnabled: >+ type: bool >+ defaultValue: true >+ webcoreBinding: RuntimeEnabledFeatures >+ >+DisabledAdaptationsMetaTagEnabled: >+ type: bool >+ defaultValue: DISABLED_ADAPTATIONS_META_TAG_ENABLED >+ webcoreBinding: RuntimeEnabledFeatures > > # For experimental features: > # The type should be boolean. >@@ -1082,28 +1109,6 @@ AsyncFrameScrollingEnabled: > humanReadableDescription: "Perform frame scrolling in a dedicated thread or process" > category: experimental > >-CacheAPIEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "Cache API" >- humanReadableDescription: "Enable Cache API" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >- >-ConstantPropertiesEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "Constant Properties" >- humanReadableDescription: "Enable CSS constant() values" >- category: experimental >- >-CrossOriginWindowPolicySupportEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "Cross-Origin-Window-Policy HTTP Header" >- humanReadableDescription: "Enable support for Cross-Origin-Window-Policy HTTP Header" >- category: experimental >- > SpringTimingFunctionEnabled: > type: bool > defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED >@@ -1178,13 +1183,6 @@ StorageAccessAPIEnabled: > humanReadableDescription: "Enable Storage Access API" > category: experimental > >-SubresourceIntegrityEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "SubresourceIntegrity" >- humanReadableDescription: "Enable SubresourceIntegrity" >- category: experimental >- > VisualViewportAPIEnabled: > type: bool > defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED >@@ -1227,12 +1225,12 @@ WebGPUEnabled: > condition: ENABLE(WEBGPU) > > AccessibilityObjectModelEnabled: >- type: bool >- defaultValue: false >- humanReadableName: "Accessibility Object Model" >- humanReadableDescription: "Accessibility Object Model support" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >+ type: bool >+ defaultValue: false >+ humanReadableName: "Accessibility Object Model" >+ humanReadableDescription: "Accessibility Object Model support" >+ category: experimental >+ webcoreBinding: RuntimeEnabledFeatures > > WebVREnabled: > type: bool >@@ -1251,22 +1249,6 @@ ResourceLoadStatisticsDebugMode: > category: experimental > webcoreBinding: RuntimeEnabledFeatures > >-RestrictedHTTPResponseAccess: >- type: bool >- defaultValue: true >- humanReadableName: "Restricted HTTP Response Access to Web Process" >- humanReadableDescription: "Restricted HTTP Response Access to Web Process" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >- >-CrossOriginResourcePolicyEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "Cross-Origin-Resource-Policy Response Header" >- humanReadableDescription: "Support for the Cross-Origin-Resource-Policy Response Header" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >- > WebGLCompressedTextureASTCSupportEnabled: > type: bool > defaultValue: false >@@ -1276,29 +1258,21 @@ WebGLCompressedTextureASTCSupportEnabled: > webcoreBinding: RuntimeEnabledFeatures > > StorageAccessPromptsEnabled: >- type: bool >- defaultValue: true >- humanReadableName: "Prompt for Storage Access API Requests" >- humanReadableDescription: "Prompt the user when Storage Access API calls are made" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >+ type: bool >+ defaultValue: true >+ humanReadableName: "Prompt for Storage Access API Requests" >+ humanReadableDescription: "Prompt the user when Storage Access API calls are made" >+ category: experimental >+ webcoreBinding: RuntimeEnabledFeatures > > ServerTimingEnabled: >- type: bool >- defaultValue: false >- humanReadableName: "Server Timing" >- humanReadableDescription: "Enable Server Timing API" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >- webcoreName: serverTimingEnabled >- >-DisabledAdaptationsMetaTagEnabled: >- type: bool >- defaultValue: DISABLED_ADAPTATIONS_META_TAG_ENABLED >- humanReadableName: "disabled-adaptations" >- humanReadableDescription: "Enable the 'disabled-adaptations' meta tag" >- category: experimental >- webcoreBinding: RuntimeEnabledFeatures >+ type: bool >+ defaultValue: false >+ humanReadableName: "Server Timing" >+ humanReadableDescription: "Enable Server Timing API" >+ category: experimental >+ webcoreBinding: RuntimeEnabledFeatures >+ webcoreName: serverTimingEnabled > > ColorFilterEnabled: > type: bool >diff --git a/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp b/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp >index 2cfb3ca1d3cc2adf4f456cdce0f6477a57f204c4..77c046cec92875f3deecd3049c89a7582f8efb92 100644 >--- a/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp >+++ b/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp >@@ -124,7 +124,7 @@ WebSWContextManagerConnection::~WebSWContextManagerConnection() = default; > void WebSWContextManagerConnection::updatePreferencesStore(const WebPreferencesStore& store) > { > RuntimeEnabledFeatures::sharedFeatures().setServiceWorkerEnabled(true); >- RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::cacheAPIEnabledKey())); >+ RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::serviceWorkersEnabledKey())); > RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::fetchAPIEnabledKey())); > RuntimeEnabledFeatures::sharedFeatures().setUserTimingEnabled(store.getBoolValueForKey(WebPreferencesKey::userTimingEnabledKey())); > RuntimeEnabledFeatures::sharedFeatures().setResourceTimingEnabled(store.getBoolValueForKey(WebPreferencesKey::resourceTimingEnabledKey()));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187047
:
343604
|
343609
|
343627