Attachment 343603 Details for Bug 187046 – ROLLOUT of r233143

[patch] ROLLOUT of r233143

bug-187046-20180626112524.patch (text/plain), 1.79 KB, created by WebKit Commit Bot on 2018-06-26 08:25:24 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2018-06-26 08:25:24 PDT

Size: 1.79 KB

patch

obsolete

>Subversion Revision: 233199
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 42d33ee911bc53a4a0a8da29356b6f5f1790d338..246c4717f6c64f60ffd575b6f14dc3d5b67f0097 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-26  Commit Queue  <commit-queue@webkit.org>
>+
>+        Unreviewed, rolling out r233143.
>+        https://bugs.webkit.org/show_bug.cgi?id=187046
>+
>+        broke media/video-ended-event-negative-playback.html
>+        (Requested by philn on #webkit).
>+
>+        Reverted changeset:
>+
>+        "[GStreamer] Remove useless workaround"
>+        https://bugs.webkit.org/show_bug.cgi?id=186921
>+        https://trac.webkit.org/changeset/233143
>+
> 2018-06-25  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Computed height for in-flow non-replaced should not include padding and border.
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index fad673e54065b878a837e148be5ca508df1f66f7..4b438b54a47540790351b672cb7c88aae3b7c527 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -487,6 +487,14 @@ MediaTime MediaPlayerPrivateGStreamer::currentMediaTime() const
>     if (m_seeking)
>         return m_seekTime;
> 
>+    // Workaround for
>+    // https://bugzilla.gnome.org/show_bug.cgi?id=639941 In GStreamer
>+    // 0.10.35 basesink reports wrong duration in case of EOS and
>+    // negative playback rate. There's no upstream accepted patch for
>+    // this bug yet, hence this temporary workaround.
>+    if (m_isEndReached && m_playbackRate < 0)
>+        return MediaTime::invalidTime();
>+
>     return playbackPosition();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 187046: 343603