Attachment 343602 Details for Bug 187043 – Patch

[patch] Patch

bug-187043-20180626073730.patch (text/plain), 2.52 KB, created by zalan on 2018-06-26 07:37:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: zalan

Created: 2018-06-26 07:37:31 PDT

Size: 2.52 KB

patch

obsolete

>Subversion Revision: 233198
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 42d33ee911bc53a4a0a8da29356b6f5f1790d338..c0a93c0e0fd0644573130d55cc0eb9591034380a 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-26  Zalan Bujtas  <zalan@apple.com>
>+
>+        [LFC] Fixed positioning is a subcategory of absolute positioning.
>+        https://bugs.webkit.org/show_bug.cgi?id=187043
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
>+        References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
>+        property has the value 'absolute' or 'fixed'.
>+
>+        * layout/layouttree/LayoutBox.cpp:
>+        (WebCore::Layout::Box::isAbsolutelyPositioned const):
>+        * layout/layouttree/LayoutBox.h:
>+        (WebCore::Layout::Box::isOutOfFlowPositioned const):
>+
> 2018-06-25  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Computed height for in-flow non-replaced should not include padding and border.
>diff --git a/Source/WebCore/layout/layouttree/LayoutBox.cpp b/Source/WebCore/layout/layouttree/LayoutBox.cpp
>index 71c09c26511ed894857c979f2e77bf22fc2bf277..591c9b248bc4e406a891545b525d2a71c20180ab 100644
>--- a/Source/WebCore/layout/layouttree/LayoutBox.cpp
>+++ b/Source/WebCore/layout/layouttree/LayoutBox.cpp
>@@ -82,7 +82,7 @@ bool Box::isStickyPositioned() const
> 
> bool Box::isAbsolutelyPositioned() const
> {
>-    return m_style.position() == PositionType::Absolute;
>+    return m_style.position() == PositionType::Absolute || isFixedPositioned(); 
> }
> 
> bool Box::isFixedPositioned() const
>diff --git a/Source/WebCore/layout/layouttree/LayoutBox.h b/Source/WebCore/layout/layouttree/LayoutBox.h
>index 718ae85446ce5b7d6e3581ed444cd358e88230b4..b1ea8e096f2bc823cb1c58c0b140c577627db8e7 100644
>--- a/Source/WebCore/layout/layouttree/LayoutBox.h
>+++ b/Source/WebCore/layout/layouttree/LayoutBox.h
>@@ -53,7 +53,7 @@ public:
>     bool isInFlow() const { return !isFloatingOrOutOfFlowPositioned(); }
>     bool isPositioned() const { return isInFlowPositioned() || isOutOfFlowPositioned(); }
>     bool isInFlowPositioned() const { return isRelativelyPositioned() || isStickyPositioned(); }
>-    bool isOutOfFlowPositioned() const { return isAbsolutelyPositioned() || isFixedPositioned(); }
>+    bool isOutOfFlowPositioned() const { return isAbsolutelyPositioned(); }
>     bool isRelativelyPositioned() const;
>     bool isStickyPositioned() const;
>     bool isAbsolutelyPositioned() const;

Actions: View | Formatted Diff | Diff

Attachments on bug 187043: 343602