WebKit Bugzilla
Attachment 343597 Details for
Bug 187038
: Fix testapi build when DFG_JIT is disabled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187038-20180626122335.patch (text/plain), 1.63 KB, created by
Tadeu Zagallo
on 2018-06-26 03:23:37 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tadeu Zagallo
Created:
2018-06-26 03:23:37 PDT
Size:
1.63 KB
patch
obsolete
>Subversion Revision: 233195 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 6138c15e7b8113b0089d750513281e5bb65dde6f..eb6a95344e1ea660c349fe9e7090c37190d61816 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-06-26 Tadeu Zagallo <tzagallo@apple.com> >+ >+ Fix testapi build when DFG_JIT is disabled >+ https://bugs.webkit.org/show_bug.cgi?id=187038 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ r233158 added a new API and tests for configuring the number of JIT threads, but >+ the API is only available when DFG_JIT is enabled and so should the tests. >+ >+ * API/tests/testapi.mm: >+ (runJITThreadLimitTests): >+ > 2018-06-25 Saam Barati <sbarati@apple.com> > > JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary >diff --git a/Source/JavaScriptCore/API/tests/testapi.mm b/Source/JavaScriptCore/API/tests/testapi.mm >index 9b01f880811e6ed1f977887422adaf277ae92564..a1654ae11e191a6492c55368d8ebd0d5619d18a2 100644 >--- a/Source/JavaScriptCore/API/tests/testapi.mm >+++ b/Source/JavaScriptCore/API/tests/testapi.mm >@@ -521,6 +521,7 @@ static void* multiVMThreadMain(void* okPtr) > > static void runJITThreadLimitTests() > { >+#if ENABLE(DFG_JIT) > auto testDFG = [] { > unsigned defaultNumberOfThreads = JSC::Options::numberOfDFGCompilerThreads(); > unsigned targetNumberOfThreads = 1; >@@ -548,6 +549,7 @@ static void runJITThreadLimitTests() > testFTL(); > JSC::DFG::ensureGlobalFTLWorklist(); > testFTL(); >+#endif // ENABLE(DFG_JIT) > } > > static void testObjectiveCAPIMain()
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mark.lam
:
review+
ews-watchlist
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187038
: 343597 |
343600
|
343601