Attachment 343591 Details for Bug 186189 – WIP patch

[patch] WIP patch

bug-186189-20180626090439.patch (text/plain), 2.38 KB, created by Zan Dobersek on 2018-06-26 00:04:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2018-06-26 00:04:40 PDT

Size: 2.38 KB

patch

obsolete

>Subversion Revision: 233190
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index e7623c788adec1e7390dbb9fc19824c187ceae92..657345229d865173a4b4f6eee603410cb6f359e6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-26  Zan Dobersek  <zdobersek@igalia.com>
>+
>+        Crash in WebAnimation::runPendingPlayTask
>+        https://bugs.webkit.org/show_bug.cgi?id=186189
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests (OOPS!).
>+
>+        * animation/WebAnimation.cpp:
>+        (WebCore::WebAnimation::runPendingPlayTask):
>+        (WebCore::WebAnimation::runPendingPauseTask):
>+
> 2018-06-25  Keith Rollin  <krollin@apple.com>
> 
>         Adjust WEBCORE_EXPORT annotations for LTO
>diff --git a/Source/WebCore/animation/WebAnimation.cpp b/Source/WebCore/animation/WebAnimation.cpp
>index 9753c0183c094f3340524fb4222739838d1ccdcf..f4777d14cc91e2363363946c1d021fd92ea6fae7 100644
>--- a/Source/WebCore/animation/WebAnimation.cpp
>+++ b/Source/WebCore/animation/WebAnimation.cpp
>@@ -835,7 +835,8 @@ void WebAnimation::runPendingPlayTask()
>     if (!m_startTime) {
>         // 1. Let new start time be the result of evaluating ready time - hold time / animation playback rate for animation.
>         // If the animation playback rate is zero, let new start time be simply ready time.
>-        auto newStartTime = readyTime.value();
>+        // FIXME: <explanation>
>+        auto newStartTime = readyTime.value_or(Seconds());
>         if (m_playbackRate)
>             newStartTime -= m_holdTime.value() / m_playbackRate;
>         // 2. If animation's playback rate is not 0, make animation's hold time unresolved.
>@@ -962,8 +963,10 @@ void WebAnimation::runPendingPauseTask()
>     //    evaluating (ready time - start time) Ã playback rate.
>     //    Note: The hold time might be already set if the animation is finished, or if the animation is pending, waiting to begin
>     //    playback. In either case we want to preserve the hold time as we enter the paused state.
>-    if (animationStartTime && !m_holdTime)
>-        setHoldTime((readyTime.value() - animationStartTime.value()) * m_playbackRate);
>+    if (animationStartTime && !m_holdTime) {
>+        // FIXME: <explanation>
>+        setHoldTime((readyTime.value_or(Seconds()) - animationStartTime.value()) * m_playbackRate);
>+    }
> 
>     // 3. Make animation's start time unresolved.
>     setStartTime(std::nullopt);

Actions: View | Formatted Diff | Diff

Attachments on bug 186189: 341746 | 341747 | 341748 | 341749 | 341750 | 341756 | 343591 | 343596