Attachment 343586 Details for Bug 187018 – Patch

[patch] Patch

bug-187018-20180625230642.patch (text/plain), 5.05 KB, created by youenn fablet on 2018-06-25 23:06:43 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-06-25 23:06:43 PDT

Size: 5.05 KB

patch

obsolete

>Subversion Revision: 233130
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index baa848d7fe8167e090fceb6789d8239236798482..40ff84157086422bf9324ae380e48a38afa21401 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-25  Youenn Fablet  <youenn@apple.com>
>+
>+        Update Cisco Webex sandbox to make it functional
>+        https://bugs.webkit.org/show_bug.cgi?id=187018
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        These cisco sandbox changes allow removing sandbox errors and makes the plug-in almost functional modulo quarantine of downloaded files.
>+
>+        * Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb:
>+
> 2018-06-25  Youenn Fablet  <youenn@apple.com>
> 
>         Add a sandbox profile to Hangout plug-in
>diff --git a/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb b/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>index ca6cf8358fac8adcf8dcbdd3a454990a850739d7..f307dc3556a3176187ef8c8a2b74b7016fc90e8c 100644
>--- a/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>+++ b/Source/WebKit/Resources/PlugInSandboxProfiles/com.cisco.webex.plugin.gpc64.sb
>@@ -28,6 +28,20 @@
> (define (home-literal home-relative-literal)
>     (literal (string-append (param "HOME_DIR") home-relative-literal)))
> 
>+(allow file-issue-extension
>+    (require-any
>+        (extension-class "com.apple.app-sandbox.read")
>+        (extension-class "com.apple.app-sandbox.read-write")))
>+
>+(allow file-read* file-write*
>+    (literal "/Library/ScriptingAdditions"))
>+
>+(allow file-read* file-write*
>+    (home-subpath "/Library/Saved Application State/com.webex.meetingmanager.savedState"))
>+
>+(allow file-read* file-write*
>+    (home-subpath "/Library/Caches/com.webex.meetingmanager"))
>+
> (allow file-read* file-write*
>     (home-literal "/Library/Preferences/com.cisco.webex.fuzzyWindowConfig.plist"))
> 
>@@ -37,40 +51,71 @@
> (allow file-read* file-write* file-write-create
>     (home-subpath "/Library/Application Support/WebEx Folder"))
> 
>+(allow file-read*
>+    (home-literal "/Library/Preferences/com.apple.AppleMultitouchTrackpad.plist"))
>+
>+(allow file-read-data
>+    (home-literal "/Library/Preferences/com.apple.LaunchServices/com.apple.launchservices.secure.plist"))
>+
> ;; FIXME: We should tigthen the sandbox to some tmp subfolders
> (allow file*
>     (prefix "/private/tmp"))
> 
>+(allow file*
>+    (prefix "/private/var/folders"))
>+
>+
> (allow file-read-data file-write-data
>     (path "/dev/tty"))
> 
>+(allow distributed-notification-post)
> (allow process-exec)
> (allow process-fork)
>-(allow distributed-notification-post)
>+(allow signal)
> 
> (allow mach-lookup
>     (global-name "com.apple.PerformanceAnalysis.animationperfd")
>+    (global-name "com.apple.audio.SystemSoundServer-OSX")
>+    (global-name "com.apple.coreservices.sharedfilelistd.xpc")
>+    (global-name "com.apple.dockling.server")
>     (global-name "com.apple.dock.fullscreen")
>-    (global-name "com.apple.quicklook.ui.helper.active")
>-    (global-name "com.apple.quicklook.ui.helper")
>     (global-name "com.apple.inputmethodkit.launchagent")
>     (global-name "com.apple.inputmethodkit.launcher")
>-    (global-name "com.apple.inputmethodkit.getxpcendpoint"))
>+    (global-name "com.apple.inputmethodkit.getxpcendpoint")
>+    (global-name "com.apple.quicklook.ui.helper.active")
>+    (global-name "com.apple.quicklook.ui.helper")
>+    (global-name "com.apple.iohideventsystem"))
>+
>+(allow iokit-open
>+    (iokit-user-client-class "IOHIDLibUserClient"))
> 
> (allow iokit-get-properties
>+    (iokit-property "mt-device-id")
>+    (iokit-property "AccurateMaxDigitizerPressureValue")
>+    (iokit-property "ActivationThresholds")
>+    (iokit-property "AnimationThresholds")
>+    (iokit-property "CompactVRAM")
>+    (iokit-property "EnableBlitLib")
>+    (iokit-property "ExtendedMaxDigitizerPressureValue")
>+    (iokit-property "ForceDisableEDRAM")
>+    (iokit-property "HIDClickTime")
>+    (iokit-property "HIDParameters")
>+    (iokit-property "MetalCoalesce")
>+    (iokit-property "MetalStatisticsScriptName")
>+    (iokit-property "MinDigitizerPressureValue")
>+    (iokit-property "OSKernelCPUType")
>+    (iokit-property "OSKernelCPUSubtype")
>+    (iokit-property "PanicOnGPUHang")
>     (iokit-property "PowerControlSupported")
>-    (iokit-property "SupportTapToWake")
>     (iokit-property "ResetOnLockMs")
>     (iokit-property "ResetOnUnlockMs")
>     (iokit-property "ShouldResetOnButton")
>-    (iokit-property "WirelessChargingNotificationSupported")
>+    (iokit-property "SupportTapToWake")
>     (iokit-property "SupportsSilentClick")
>-    (iokit-property "MinDigitizerPressureValue")
>-    (iokit-property "AccurateMaxDigitizerPressureValue")
>-    (iokit-property "ExtendedMaxDigitizerPressureValue")
>-    (iokit-property "AnimationThresholds")
>-    (iokit-property "ActivationThresholds")
>-    (iokit-property "mt-device-id"))
>+    (iokit-property "TelemetryDisable")
>+    (iokit-property "USB Product Name")
>+    (iokit-property "VendorID")
>+    (iokit-property "WirelessChargingNotificationSupported"))
> 
> (webkit-powerbox)
> (webkit-printing)

Actions: View | Formatted Diff | Diff

Attachments on bug 187018: 343543 | 343586 | 343668 | 343696 | 343711 | 343730