WebKit Bugzilla
Attachment 343583 Details for
Bug 187032
: Log a message when fetching attachment data from the status server
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-187032-20180625214108.patch (text/plain), 1.67 KB, created by
Daniel Bates
on 2018-06-25 21:41:08 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-06-25 21:41:08 PDT
Size:
1.67 KB
patch
obsolete
>Subversion Revision: 233189 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 9cb9fb3e02c2fe8e140473fdad543ecc59868965..a916929c8c7e59c47f71e62d57d37a176609c66b 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,19 @@ >+2018-06-25 Daniel Bates <dabates@apple.com> >+ >+ Log a message when fetching attachment data from the status server >+ https://bugs.webkit.org/show_bug.cgi?id=187032 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Currently we silently fetch from the status server an attachment when fetching >+ the attachment from Bugzilla fails due to an access denied error. Instead we >+ should emit a message when fetching data from the status server to indicate >+ that webkit-patch/EWS is still processing the command/trying to obtain the >+ patch. >+ >+ * Scripts/webkitpy/common/net/statusserver.py: >+ (StatusServer._fetch_attachment_page): >+ > 2018-06-25 Aakash Jain <aakash_jain@apple.com> > > [ews-build] Add support for Bindings-tests-EWS >diff --git a/Tools/Scripts/webkitpy/common/net/statusserver.py b/Tools/Scripts/webkitpy/common/net/statusserver.py >index ec6d5022309af7c8277668b0dbb422307d9f8dff..9aa827461f987f3879fd0553ec886cf9166723d5 100644 >--- a/Tools/Scripts/webkitpy/common/net/statusserver.py >+++ b/Tools/Scripts/webkitpy/common/net/statusserver.py >@@ -203,6 +203,7 @@ class StatusServer: > > def _fetch_attachment_page(self, action, attachment_id): > attachment_url = '{}/attachment/{}/{}'.format(self._server_url(), action, attachment_id) >+ _log.info('Fetching: {}'.format(attachment_url)) > return self._fetch_url(attachment_url) > > def fetch_attachment(self, attachment_id):
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
zalan
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 187032
: 343583