Attachment 343560 Details for Bug 186976 – Patch

[patch] Patch

patch.txt (text/plain), 2.53 KB, created by Nikita Vasilyev on 2018-06-25 17:03:58 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-06-25 17:03:58 PDT

Size: 2.53 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 6d68f5fa988..c468724b7b4 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-25  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: Box Model section should have dark background
>+        https://bugs.webkit.org/show_bug.cgi?id=186976
>+
>+        Reviewed by Brian Burg.
>+
>+        Replace all instances of black text on white background with the default text and background colors.
>+
>+        * UserInterface/Views/BoxModelDetailsSectionRow.css:
>+        (@media (prefers-dark-interface)):
>+        (.details-section .row.box-model):
>+        (.details-section .row.box-model .label):
>+        (.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
>+        (.details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),):
>+        (.details-section .row.box-model .margin):
>+        (.details-section .row.box-model .border):
>+
> 2018-06-25  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: Dark Mode: color outline is too dark
>diff --git a/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css b/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css
>index ff9e8743fae..b1c23dfe893 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.css
>@@ -108,3 +108,32 @@ body[dir=rtl] .details-section .row.box-model .label {
> .details-section .row.box-model :matches(.right, .left) {
>     vertical-align: middle;
> }
>+
>+@media (prefers-dark-interface) {
>+    .details-section .row.box-model {
>+        color: var(--text-color);
>+    }
>+
>+    .details-section .row.box-model .label {
>+        color: inherit;
>+    }
>+
>+    .details-section .row.box-model :matches(.position, .margin, .border, .padding, .content) {
>+        border-color: var(--text-color-quaternary);
>+        background-color: var(--background-color);
>+        color: var(--text-color);
>+    }
>+
>+    .details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),
>+    .details-section .row.box-model .active:matches(.margin, .border, .padding, .content) {
>+        color: black;
>+    }
>+
>+    .details-section .row.box-model .margin {
>+        border-color: var(--text-color-quaternary);
>+    }
>+
>+    .details-section .row.box-model .border {
>+        border-color: var(--text-color-quaternary);
>+    }
>+}

Actions: View | Formatted Diff | Diff

Attachments on bug 186976: 343455 | 343459 | 343460 | 343465 | 343560