Attachment 343556 Details for Bug 187023 – Proposed patch

[patch] Proposed patch

ews_webkitperl.patch (text/plain), 4.33 KB, created by Aakash Jain on 2018-06-25 16:38:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-06-25 16:38:28 PDT

Size: 4.33 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 233179)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-06-25  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add support for Webkitperl-tests-EWS
>+        https://bugs.webkit.org/show_bug.cgi?id=187023
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/config.json: Added Webkitperl-tests-EWS.
>+        * BuildSlaveSupport/ews-build/factories.py: Added WebkitperlFactory.
>+        * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebkitperlTests.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
>+
> 2018-06-25  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Add support for Bindings-tests-EWS
>Index: Tools/BuildSlaveSupport/ews-build/config.json
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/config.json	(revision 233176)
>+++ Tools/BuildSlaveSupport/ews-build/config.json	(working copy)
>@@ -265,6 +265,12 @@
>       "factory": "WebkitpyFactory",
>       "platform": "*",
>       "workernames": ["webkit-misc"]
>+    },
>+    {
>+      "name": "Webkitperl-tests-EWS",
>+      "factory": "WebkitperlFactory",
>+      "platform": "*",
>+      "workernames": ["webkit-misc"]
>     }
>   ],
>   "schedulers": [
>Index: Tools/BuildSlaveSupport/ews-build/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/factories.py	(revision 233176)
>+++ Tools/BuildSlaveSupport/ews-build/factories.py	(working copy)
>@@ -45,6 +45,12 @@ class BindingsFactory(Factory):
>         self.addStep(RunBindingsTests())
> 
> 
>+class WebkitperlFactory(Factory):
>+    def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
>+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
>+        self.addStep(RunWebkitperlTests())
>+
>+
> class GTKFactory(Factory):
>     pass
> 
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 233176)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -79,3 +79,11 @@ class RunBindingsTests(shell.ShellComman
>     descriptionDone = ['bindings-tests']
>     flunkOnFailure = True
>     command = ['Tools/Scripts/run-bindings-tests']
>+
>+
>+class RunWebkitperlTests(shell.ShellCommand):
>+    name = 'webkitperl-tests'
>+    description = ['webkitperl-tests running']
>+    descriptionDone = ['webkitperl-tests']
>+    flunkOnFailure = True
>+    command = ['Tools/Scripts/test-webkitperl']
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 233176)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -260,5 +260,40 @@ class TestRunBindingsTests(BuildStepMixi
>         return self.runStep()
> 
> 
>+class TestRunWebkitperlTests(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_success(self):
>+        self.setupStep(RunWebkitperlTests())
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['Tools/Scripts/test-webkitperl'],
>+                        )
>+            + 0,
>+        )
>+        self.expectOutcome(result=SUCCESS, state_string='webkitperl-tests')
>+        return self.runStep()
>+
>+    def test_failure(self):
>+        self.setupStep(RunWebkitperlTests())
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['Tools/Scripts/test-webkitperl'],
>+                        )
>+            + ExpectShell.log('stdio', stdout='''Failed tests:  1-3, 5-7, 9, 11-13
>+Files=40, Tests=630,  4 wallclock secs ( 0.16 usr  0.09 sys +  2.78 cusr  0.64 csys =  3.67 CPU)
>+Result: FAIL
>+Failed 1/40 test programs. 10/630 subtests failed.''')
>+            + 2,
>+        )
>+        self.expectOutcome(result=FAILURE, state_string='webkitperl-tests (failure)')
>+        return self.runStep()
>+
>+
> if __name__ == '__main__':
>     unittest.main()

Flags:

lforschler: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 187023: 343556 | 343599