Attachment 343542 Details for Bug 187017 – Patch

[patch] Patch

bug-187017-20180625144316.patch (text/plain), 1.85 KB, created by Tim Horton on 2018-06-25 14:43:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2018-06-25 14:43:17 PDT

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 233108
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 35818f0d8d34515b3cfbe5d6b80ee520c192336f..8ca976061e12e679ee6b0f5b22230c8b6a3f5e42 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-06-25  Tim Horton  <timothy_horton@apple.com>
>+
>+        WKThumbnailView fallback background is blindingly bright in Dark Mode
>+        https://bugs.webkit.org/show_bug.cgi?id=187017
>+        <rdar://problem/41036209>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/_WKThumbnailView.mm:
>+        (-[_WKThumbnailView initWithFrame:]):
>+        (-[_WKThumbnailView wantsUpdateLayer]):
>+        (-[_WKThumbnailView updateLayer]):
>+        Use a semantic color for the WKThumbnailView background color
>+        instead of flat white.
>+
> 2018-06-22  Sihui Liu  <sihui_liu@apple.com>
> 
>         REGRESSION (r231850): Cookie file cannot be read or written by network process
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm b/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
>index 4ea1c5826a5b1f7f5ff83a70d2ead9e3fcc9ae66..f89218aa1c5a4c185e300fe10f7385d72b93badc 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm
>@@ -70,7 +70,6 @@ - (instancetype)initWithFrame:(NSRect)frame
>         return nil;
> 
>     self.wantsLayer = YES;
>-    self.layer.backgroundColor = [NSColor whiteColor].CGColor;
>     _scale = 1;
>     _lastSnapshotScale = NAN;
>     
>@@ -103,6 +102,18 @@ - (instancetype)initWithFrame:(NSRect)frame fromWKWebView:(WKWebView *)webView
>     return self;
> }
> 
>+- (BOOL)wantsUpdateLayer
>+{
>+    return YES;
>+}
>+
>+- (void)updateLayer
>+{
>+    [super updateLayer];
>+
>+    self.layer.backgroundColor = [NSColor quaternaryLabelColor].CGColor;
>+}
>+
> - (void)requestSnapshot
> {
>     if (_waitingForSnapshot) {

Actions: View | Formatted Diff | Diff

Attachments on bug 187017: 343542