Attachment 343537 Details for Bug 187016 – Patch

[patch] Patch

bug-187016-20180625141944.patch (text/plain), 1.84 KB, created by Chris Dumez on 2018-06-25 14:19:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-25 14:19:44 PDT

Size: 1.84 KB

patch

obsolete

>Subversion Revision: 233171
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f41c8dab0156dd96cf92bc50ef8461a4e85bbc29..ea564d76a5a23a9289ad06ff3cca8e09a8000487 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-25  Chris Dumez  <cdumez@apple.com>
>+
>+        Simplify NetworkStorageSession::getAllStorageAccessEntries()
>+        https://bugs.webkit.org/show_bug.cgi?id=187016
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Iterate over the whole HashMaps instead of iterating over their keys and then looking them
>+        up in the HashMap.
>+
>+        * platform/network/cf/NetworkStorageSessionCFNet.cpp:
>+        (WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
>+
> 2018-06-25  Chris Dumez  <cdumez@apple.com>
> 
>         Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
>diff --git a/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp b/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>index 22746f04417edc93d1d2a12d07526bdb2b31362f..6d3fce94a6561d7c4265d56bb8ce8e796562a020 100644
>--- a/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>+++ b/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
>@@ -331,10 +331,9 @@ bool NetworkStorageSession::hasStorageAccess(const String& resourceDomain, const
> Vector<String> NetworkStorageSession::getAllStorageAccessEntries() const
> {
>     Vector<String> entries;
>-    for (auto& pageID : m_framesGrantedStorageAccess.keys()) {
>-        auto it1 = m_framesGrantedStorageAccess.find(pageID);
>-        for (auto& frameID : it1->value.keys())
>-            entries.append(it1->value.find(frameID)->value);
>+    for (auto& pair : m_framesGrantedStorageAccess) {
>+        for (auto& innerPair : pair.value)
>+            entries.append(innerPair.value);
>     }
>     return entries;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 187016: 343537 | 343578 | 343635