Attachment 343535 Details for Bug 187014 – Proposed patch

[patch] Proposed patch

ews_bindings_ews.patch (text/plain), 3.75 KB, created by Aakash Jain on 2018-06-25 13:57:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-06-25 13:57:49 PDT

Size: 3.75 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 233170)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-06-25  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add support for Bindings-tests-EWS
>+        https://bugs.webkit.org/show_bug.cgi?id=187014
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/factories.py:
>+        (BindingsFactory): Added RunBindingsTests build step to BindingsFactory.
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (RunBindingsTests): Added build-step for running Bindings tests.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
>+
> 2018-06-25  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Add support for Style-EWS
>Index: Tools/BuildSlaveSupport/ews-build/factories.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/factories.py	(revision 233170)
>+++ Tools/BuildSlaveSupport/ews-build/factories.py	(working copy)
>@@ -39,6 +39,12 @@ class StyleFactory(Factory):
>         self.addStep(CheckStyle())
> 
> 
>+class BindingsFactory(Factory):
>+    def __init__(self, platform, configuration=None, architectures=None, additionalArguments=None, **kwargs):
>+        Factory.__init__(self, platform, configuration, architectures, False, additionalArguments)
>+        self.addStep(RunBindingsTests())
>+
>+
> class GTKFactory(Factory):
>     pass
> 
>@@ -75,9 +81,5 @@ class JSCTestsFactory(Factory):
>     pass
> 
> 
>-class BindingsFactory(Factory):
>-    pass
>-
>-
> class WebkitpyFactory(Factory):
>     pass
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 233170)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -71,3 +71,11 @@ class CheckStyle(shell.ShellCommand):
>     descriptionDone = ['check-webkit-style']
>     flunkOnFailure = True
>     command = ['Tools/Scripts/check-webkit-style']
>+
>+
>+class RunBindingsTests(shell.ShellCommand):
>+    name = 'bindings-tests'
>+    description = ['bindings-tests running']
>+    descriptionDone = ['bindings-tests']
>+    flunkOnFailure = True
>+    command = ['Tools/Scripts/run-bindings-tests']
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 233170)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -228,5 +228,37 @@ Total errors found: 8 in 48 files''')
>         return self.runStep()
> 
> 
>+class TestRunBindingsTests(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_success(self):
>+        self.setupStep(RunBindingsTests())
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['Tools/Scripts/run-bindings-tests'],
>+                        )
>+            + 0,
>+        )
>+        self.expectOutcome(result=SUCCESS, state_string='bindings-tests')
>+        return self.runStep()
>+
>+    def test_failure(self):
>+        self.setupStep(RunBindingsTests())
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['Tools/Scripts/run-bindings-tests'],
>+                        )
>+            + ExpectShell.log('stdio', stdout='FAIL: (JS) JSTestInterface.cpp')
>+            + 2,
>+        )
>+        self.expectOutcome(result=FAILURE, state_string='bindings-tests (failure)')
>+        return self.runStep()
>+
>+
> if __name__ == '__main__':
>     unittest.main()

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 187014: 343535