Attachment 343526 Details for Bug 186938 – Patch

[patch] Patch

bug-186938-20180625124732.patch (text/plain), 2.54 KB, created by Chris Dumez on 2018-06-25 12:47:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-25 12:47:33 PDT

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 233146
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9d67f5c3f7366efc2084b74d4f421086966c220a..04a8b3a2a8f46bb9d4de63411452f1c81b7f2a42 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-25  Chris Dumez  <cdumez@apple.com>
>+
>+        performance-api/performance-observer-no-document-leak.html is flaky
>+        https://bugs.webkit.org/show_bug.cgi?id=186938
>+        <rdar://problem/41379336>
>+
>+        Unreviewed, move the call to gc() inside the setInterval() so we keep
>+        trying to gc() until the frame / document are destroyed (instead of
>+        only doing a single garbage collection).
>+
>+        * TestExpectations:
>+        * performance-api/performance-observer-no-document-leak.html:
>+
> 2018-06-25  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index 4c2cc1873b64053353cf9db6d6514466d2223f46..daa5dd5f8017661475a2202558cffe16845a90c6 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -2143,8 +2143,6 @@ imported/w3c/web-platform-tests/css/css-pseudo/first-letter-property-whitelist.h
> imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.https.any.html [ Pass Failure ]
> imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-OAEP.https.any.worker.html [ Pass Failure ]
> 
>-webkit.org/b/186938 performance-api/performance-observer-no-document-leak.html [ Skip ]
>-
> webkit.org/b/175609 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getAll.html [ Pass Failure ]
> 
> webkit.org/b/186848 imported/w3c/web-platform-tests/FileAPI/blob/Blob-slice.html [ Pass Failure ]
>diff --git a/LayoutTests/performance-api/performance-observer-no-document-leak.html b/LayoutTests/performance-api/performance-observer-no-document-leak.html
>index ae341f8cdf5febb5280134692362e99c7cc21be9..5aeff0766bff524ccd015e4b1aa2de6737b54573 100644
>--- a/LayoutTests/performance-api/performance-observer-no-document-leak.html
>+++ b/LayoutTests/performance-api/performance-observer-no-document-leak.html
>@@ -12,8 +12,8 @@ window.jsTestIsAsync = true;
> function numberOfDocumentsShouldBecome(count)
> {
>     return new Promise(function(resolve, reject) {
>-        gc();
>         handle = setInterval(function() {
>+            gc();
>             if (internals.numberOfLiveDocuments() == count) {
>                 testPassed("Number of document is " + count);
>                 clearInterval(handle);

Actions: View | Formatted Diff | Diff

Attachments on bug 186938: 343526 | 344235 | 344238