Attachment 343497 Details for Bug 186998 – Patch

[patch] Patch

bug-186998-20180625105339.patch (text/plain), 1.40 KB, created by Leo Balter on 2018-06-25 07:53:40 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-06-25 07:53:40 PDT

Size: 1.40 KB

patch

obsolete

>Subversion Revision: 233144
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 086eb7ee968b84c42363b630ff144a4848be3505..e9c5b36885347ec81f259fb7d1385fe5d0b3420c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-25  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        [test262-runner] Sort the list of failing files in the HTML report
>+        https://bugs.webkit.org/show_bug.cgi?id=186998
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (printHTMLResults): The current list of failing files it not ordered and it's hard to read.
>+        This small patch will sort the list.
>+
> 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [WTF] Add user-defined literal for ASCIILiteral
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 1c08e61002714fd70660f3a71419075db07f0ed6..3fe2f4f3c40099458e51515403b2eb6ac23441fc 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -1166,7 +1166,8 @@ sub printHTMLResults {
> 
>     print $htmlfh qq{</ul><h2>Failures</h2><ul>};
> 
>-    while (my ($path, $scenarios) = each %failed) {
>+    foreach my $path (sort keys %failed) {
>+        my $scenarios = $failed{$path};
>         print $htmlfh qq{<li class="list-item">
>             <label for="$path" class="expander-control">$path</label>
>             <input type="checkbox" id="$path" class="expander">

Actions: View | Formatted Diff | Diff

Attachments on bug 186998: 343497