Attachment 343491 Details for Bug 186995 – Patch

[patch] Patch

bug-186995-20180625174319.patch (text/plain), 2.54 KB, created by Yusuke Suzuki on 2018-06-25 01:43:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-06-25 01:43:20 PDT

Size: 2.54 KB

patch

obsolete

>Subversion Revision: 233138
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index ee293a76ba3ca3220a62a70e8ce888b0d040fc8e..f8db8aa5e1128083d50f7fdd6b68f183cbe298e0 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-25  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [JSC] Remove unnecessary PLATFORM guards
>+        https://bugs.webkit.org/show_bug.cgi?id=186995
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * assembler/AssemblerCommon.h:
>+        (JSC::isIOS):
>+        Add constexpr.
>+
>+        * inspector/JSGlobalObjectInspectorController.cpp:
>+        (Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
>+        StackFrame works in all the platforms. If StackFrame::demangle failed,
>+        it just returns std::nullopt. And it is correctly handled in this code.
>+
> 2018-06-23  Mark Lam  <mark.lam@apple.com>
> 
>         Add more debugging features to $vm.
>diff --git a/Source/JavaScriptCore/assembler/AssemblerCommon.h b/Source/JavaScriptCore/assembler/AssemblerCommon.h
>index 2c6cb35f315b078733dad0525e226ea2eee94e5c..762a7a63b94aff1749a689146f34a430c75e5801 100644
>--- a/Source/JavaScriptCore/assembler/AssemblerCommon.h
>+++ b/Source/JavaScriptCore/assembler/AssemblerCommon.h
>@@ -27,7 +27,7 @@
> 
> namespace JSC {
> 
>-ALWAYS_INLINE bool isIOS()
>+ALWAYS_INLINE constexpr bool isIOS()
> {
> #if PLATFORM(IOS)
>     return true;
>diff --git a/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp b/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
>index b4305b78729fdbce25fad67a62d13ff7ec2ababb..d4d7aa18686641411ff87bdda680e900695b9190 100644
>--- a/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
>+++ b/Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
>@@ -180,7 +180,6 @@ void JSGlobalObjectInspectorController::dispatchMessageFromFrontend(const String
> 
> void JSGlobalObjectInspectorController::appendAPIBacktrace(ScriptCallStack& callStack)
> {
>-#if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK))
>     static const int framesToShow = 31;
>     static const int framesToSkip = 3; // WTFGetBacktrace, appendAPIBacktrace, reportAPIException.
> 
>@@ -197,9 +196,6 @@ void JSGlobalObjectInspectorController::appendAPIBacktrace(ScriptCallStack& call
>         else
>             callStack.append(ScriptCallFrame("?"_s, "[native code]"_s, noSourceID, 0, 0));
>     }
>-#else
>-    UNUSED_PARAM(callStack);
>-#endif
> }
> 
> void JSGlobalObjectInspectorController::reportAPIException(ExecState* exec, Exception* exception)

Actions: View | Formatted Diff | Diff

Attachments on bug 186995: 343491