Attachment 343479 Details for Bug 186986 – Patch

[patch] Patch

patch.txt (text/plain), 2.23 KB, created by Nikita Vasilyev on 2018-06-24 20:15:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-06-24 20:15:38 PDT

Size: 2.23 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 3de404673d4..ce77010c32e 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-24  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: Font guideline colors are too bright
>+        https://bugs.webkit.org/show_bug.cgi?id=186986
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make the guidelines less distractive from the font glyphs.
>+
>+        * UserInterface/Views/DarkMode.css:
>+        (@media (prefers-dark-interface)):
>+        (.content-view.resource.font .preview > .line):
>+        (.content-view.resource.font .metric.top):
>+        (.content-view.resource.font .metric.baseline):
>+        (.content-view.resource.font .metric.middle):
>+        (.content-view.resource.font .metric.xheight):
>+        (.content-view.resource.font .metric.bottom):
>+
> 2018-06-20  Daniel Bates  <dabates@apple.com>
> 
>         Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>index f38914357c0..06ecb20c540 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>@@ -868,6 +868,33 @@
>     }
> 
> 
>+    /* FontResourceContentView.css */
>+    .content-view.resource.font .preview > .line {
>+        border-left-color: var(--text-color-quaternary);
>+        border-right-color: var(--text-color-quaternary);
>+    }
>+
>+    .content-view.resource.font .metric.top {
>+        background-color: var(--text-color-quaternary);
>+    }
>+
>+    .content-view.resource.font .metric.baseline {
>+        background-color: hsl(195, 100%, 37%);
>+    }
>+
>+    .content-view.resource.font .metric.middle {
>+        background-color: hsl(120, 100%, 35%);
>+    }
>+
>+    .content-view.resource.font .metric.xheight {
>+        background-color: hsl(350, 100%, 40%);
>+    }
>+
>+    .content-view.resource.font .metric.bottom {
>+        background-color: var(--text-color-quaternary);
>+    }
>+
>+
>     /* FilterBar.css */
>     .filter-bar > input[type="search"] {
>         border-color: var(--background-color-selected);

Actions: View | Formatted Diff | Diff

Attachments on bug 186986: 343478 | 343479 | 343480