Attachment 343459 Details for Bug 186976 – Patch

[patch] Patch

patch.txt (text/plain), 2.53 KB, created by Nikita Vasilyev on 2018-06-23 16:46:30 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nikita Vasilyev

Created: 2018-06-23 16:46:30 PDT

Size: 2.53 KB

patch

obsolete

>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 3de404673d4..5cac3d386d2 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-23  Nikita Vasilyev  <nvasilyev@apple.com>
>+
>+        Web Inspector: Dark Mode: Box Model section should have dark background
>+        https://bugs.webkit.org/show_bug.cgi?id=186976
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Replace all instances of black text on white background with the default text and background colors.
>+
>+        * UserInterface/Views/DarkMode.css:
>+        (@media (prefers-dark-interface)):
>+        (.details-section .row.box-model):
>+        (.details-section .row.box-model .label):
>+        (.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
>+        (.details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),):
>+        (.details-section .row.box-model .margin):
>+        (.details-section .row.box-model .border):
>+
> 2018-06-20  Daniel Bates  <dabates@apple.com>
> 
>         Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
>diff --git a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>index f38914357c0..ca97c59e06c 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>+++ b/Source/WebInspectorUI/UserInterface/Views/DarkMode.css
>@@ -735,6 +735,35 @@
>     }
> 
> 
>+    /* BoxModelDetailsSectionRow.css */
>+    .details-section .row.box-model {
>+        color: var(--text-color);
>+    }
>+
>+    .details-section .row.box-model .label {
>+        color: inherit;
>+    }
>+
>+    .details-section .row.box-model :matches(.position, .margin, .border, .padding, .content) {
>+        border-color: var(--text-color-quaternary);
>+        background-color: var(--background-color);
>+        color: var(--text-color);
>+    }
>+
>+    .details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),
>+    .details-section .row.box-model .active:matches(.margin, .border, .padding, .content) {
>+        color: black;
>+    }
>+
>+    .details-section .row.box-model .margin {
>+        border-color: var(--text-color-quaternary);
>+    }
>+
>+    .details-section .row.box-model .border {
>+        border-color: var(--text-color-quaternary);
>+    }
>+
>+
>     /* GeneralStyleDetailsSidebarPanel.css */
>     .sidebar > .panel.details.css-style > .content > .pseudo-classes > .group > label {
>         color: var(--text-color-secondary);

Flags:

bburg: review+
commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 186976: 343455 | 343459 | 343460 | 343465 | 343560