Attachment 343428 Details for Bug 186964 – Patch

[patch] Patch

bug-186964-20180623023649.patch (text/plain), 3.56 KB, created by Wenson Hsieh on 2018-06-23 02:36:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-06-23 02:36:50 PDT

Size: 3.56 KB

patch

obsolete

>Subversion Revision: 233095
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index f18a9e87c7ba47bc43c9b9bc2d196cf870bdaec0..fb912afeea9e62af0cfaff69387aa43af68450df 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,26 @@
>+2018-06-23  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        [iPad apps on macOS] Click events are broken in WKWebView
>+        https://bugs.webkit.org/show_bug.cgi?id=186964
>+        <rdar://problem/41369145>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Tapping in WKWebView currently does not dispatch click events to the page. This is because the long press loupe
>+        gesture (in the text interaction assistant) has a delay of 0 when running iOS apps on macOS, but on iOS, it's
>+        0.5. The zero delay on macOS means that the loupe gesture will be recognized before the synthetic click gesture;
>+        this, in turn, causes the synthetic click gesture to be excluded by the loupe gesture. To address this, we
>+        simply allow the click and loupe gesture to recognize simultaneously.
>+
>+        Additionally, a new hover gesture was added recently to handle macOS cursor types when hovering over selectable
>+        text. This patch also allows other gestures to recognize alongside hover gestures, which matches macOS behavior.
>+
>+        We don't have the capacity to write automated tests for this yet; I manually tested text selection, editing in
>+        some text form controls, as well as clicking on links, buttons, and other elements with click event handlers.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
>+
> 2018-06-22  Jer Noble  <jer.noble@apple.com>
> 
>         [Fullscreen] Exit fullscreen when opening a new tab
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 21fd28cb241f355dbae99485840b5ee2dfdf8240..bc513d44b5e1ec54c82d1ba989f4caa9f82a4817 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -1341,11 +1341,6 @@ static inline bool isSamePair(UIGestureRecognizer *a, UIGestureRecognizer *b, UI
> 
> - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer*)otherGestureRecognizer
> {
>-#if USE(APPLE_INTERNAL_SDK)
>-    if ([self _internalGestureRecognizer:gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:otherGestureRecognizer])
>-        return YES;
>-#endif
>-
>     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _longPressGestureRecognizer.get()))
>         return YES;
> 
>@@ -1355,6 +1350,12 @@ static inline bool isSamePair(UIGestureRecognizer *a, UIGestureRecognizer *b, UI
> #if ENABLE(MINIMAL_SIMULATOR)
>     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _textSelectionAssistant.get().loupeGesture, _textSelectionAssistant.get().forcePressGesture))
>         return YES;
>+
>+    if (isSamePair(gestureRecognizer, otherGestureRecognizer, _singleTapGestureRecognizer.get(), _textSelectionAssistant.get().loupeGesture))
>+        return YES;
>+
>+    if ([gestureRecognizer isKindOfClass:[UIHoverGestureRecognizer class]] || [otherGestureRecognizer isKindOfClass:[UIHoverGestureRecognizer class]])
>+        return YES;
> #endif
>     if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _textSelectionAssistant.get().forcePressGesture))
>         return YES;

Actions: View | Formatted Diff | Diff

Attachments on bug 186964: 343428