Attachment 343396 Details for Bug 186950 – Patch

[patch] Patch

bug-186950-20180622165408.patch (text/plain), 1.56 KB, created by Chris Dumez on 2018-06-22 16:54:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-22 16:54:08 PDT

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 233093
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 60ba70d2cddfcc3ac05ad32d019b7eb6b505180a..61cb8e9f44d346d7c91f3a22ab528279211b3d5a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-22  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression(r230211): Crash under WebInspectorClient::~WebInspectorClient()
>+        https://bugs.webkit.org/show_bug.cgi?id=186950
>+        <rdar://problem/40602069>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Re-introduce null-check that was accidentally dropped in r230211.
>+
>+        * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
>+        (WebKit::WebInspectorClient::~WebInspectorClient):
>+
> 2018-06-22  Chris Dumez  <cdumez@apple.com>
> 
>         Crash under WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul>&&)
>diff --git a/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp b/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>index 0f1d53c4412a931e895799e890b1c31a0861ca91..42648bda55b3b09cebc059739f335c5390e31c7e 100644
>--- a/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>+++ b/Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp
>@@ -72,7 +72,7 @@ WebInspectorClient::~WebInspectorClient()
>         delete layer;
>     }
> 
>-    if (m_paintRectOverlay)
>+    if (m_paintRectOverlay && m_page->corePage())
>         m_page->corePage()->pageOverlayController().uninstallPageOverlay(*m_paintRectOverlay, PageOverlay::FadeMode::Fade);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186950: 343396