Attachment 343382 Details for Bug 186923 – Patch

[patch] Patch

bug-186923-20180622154756.patch (text/plain), 2.46 KB, created by Daniel Bates on 2018-06-22 15:47:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-06-22 15:47:57 PDT

Size: 2.46 KB

patch

obsolete

>Subversion Revision: 233102
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 816980fee82bdfd885f49fd3456a490cc6f89492..fab21757675aa3d6ab48195f9fbff4982d927bb9 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-22  Daniel Bates  <dabates@apple.com>
>+
>+        Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed'
>+        https://bugs.webkit.org/show_bug.cgi?id=186923
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Attachments downloaded from the status server (http://webkit-queues.webkit.org) do not
>+        have an associated Bug object (i.e. Attachment.bug() is None) and reflect the state they
>+        were in, including flags set, at the time they were uploaded to the status server. We
>+        will add support for fetching up-to-date status info about the attachment and its bug
>+        in <https://bugs.webkit.org/show_bug.cgi?id=186817>. For now, we only check if the
>+        bug associated with the patch we are processing is closed if the attachment has a
>+        non-None Bug object.
>+
>+        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
>+        (EarlyWarningSystemTask.validate):
>+
> 2018-06-22  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         [Win] ImageDiff should use DLLLauncher
>diff --git a/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py b/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
>index 100e22234964f73d7e628a111b29ef5b99783841..985a0b1ed96f3ebf57af41e0c0c0e643ddacfa90 100644
>--- a/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
>+++ b/Tools/Scripts/webkitpy/tool/bot/earlywarningsystemtask.py
>@@ -41,11 +41,15 @@ class EarlyWarningSystemTask(PatchAnalysisTask):
>         self._should_build = should_build
> 
>     def validate(self):
>+        # FIXME: Need a way to ask the status server for latest status of a security bug.
>+        # Attachments downloaded from the status server do not have an associated bug and
>+        # reflect the Bugzilla state at the time they were uploaded to the status server.
>+        # See <https://bugs.webkit.org/show_bug.cgi?id=186817>.
>         self._patch = self._delegate.refetch_patch(self._patch)
>         if self._patch.is_obsolete():
>             self.error = "Patch is obsolete."
>             return False
>-        if self._patch.bug().is_closed():
>+        if self._patch.bug() and self._patch.bug().is_closed():
>             self.error = "Bug is already closed."
>             return False
>         if self._patch.review() == "-":

Actions: View | Formatted Diff | Diff

Attachments on bug 186923: 343382