Attachment 343365 Details for Bug 186942 – Patch

[patch] Patch

bug-186942-20180622141305.patch (text/plain), 3.68 KB, created by Jer Noble on 2018-06-22 14:13:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-06-22 14:13:06 PDT

Size: 3.68 KB

patch

obsolete

>Subversion Revision: 233096
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 35c958f6a029a91a4c02a31281614c4981b9874c..2891358f61a6b08b333857eca12fa91036c7f6d0 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-22  Jer Noble  <jer.noble@apple.com>
>+
>+        [Fullscreen] Home indicator should show and hide with status bar
>+        https://bugs.webkit.org/show_bug.cgi?id=186942
>+        <rdar://problem/41302190>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.h:
>+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
>+        (-[WKFullScreenViewController showUI]):
>+        (-[WKFullScreenViewController hideUI]):
>+        (-[WKFullScreenViewController setPrefersHomeIndicatorAutoHidden:]):
>+
> 2018-06-19  Jer Noble  <jer.noble@apple.com>
> 
>         [Fullscreen] Exit fullscreen when opening a new tab
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
>index 2d152cb02ef9cd2410a801f4e6b4de7decc10fed..3e70c21d756b81e308e71790be341717e910daef 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
>@@ -38,6 +38,7 @@ NS_ASSUME_NONNULL_BEGIN
> @property (assign, nonatomic) SEL action;
> @property (copy, nonatomic) NSString *location;
> @property (assign, nonatomic) BOOL prefersStatusBarHidden;
>+@property (assign, nonatomic) BOOL prefersHomeIndicatorAutoHidden;
> @property (assign, nonatomic, getter=isPlaying) BOOL playing;
> @property (assign, nonatomic, getter=isPictureInPictureActive) BOOL pictureInPictureActive;
> @property (assign, nonatomic) BOOL animating;
>diff --git a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>index a09c2ba16f594e17683ed112c01c04646b58a474..129d1316aab2ff0805d33d3694c84d8ae3128557 100644
>--- a/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>+++ b/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
>@@ -167,6 +167,7 @@ - (void)showUI
>         [_stackView setHidden:NO];
>         [_stackView setAlpha:1];
>         self.prefersStatusBarHidden = NO;
>+        self.prefersHomeIndicatorAutoHidden = NO;
>         [self.view removeConstraints:@[_topConstraint.get()]];
>         _topConstraint = [[_topGuide topAnchor] constraintEqualToAnchor:self.view.safeAreaLayoutGuide.topAnchor];
>         [_topConstraint setActive:YES];
>@@ -179,11 +180,13 @@ - (void)hideUI
> {
>     [NSObject cancelPreviousPerformRequestsWithTarget:self selector:@selector(hideUI) object:nil];
>     [UIView animateWithDuration:showHideAnimationDuration animations:^{
>+
>         [self.view removeConstraints:@[_topConstraint.get()]];
>         _topConstraint = [[_topGuide topAnchor] constraintEqualToAnchor:self.view.topAnchor constant:self.view.safeAreaInsets.top];
>         [_topConstraint setActive:YES];
>         [_stackView setAlpha:0];
>         self.prefersStatusBarHidden = YES;
>+        self.prefersHomeIndicatorAutoHidden = YES;
>         if (auto* manager = self._manager)
>             manager->setFullscreenControlsHidden(true);
>     } completion:^(BOOL finished) {
>@@ -215,6 +218,14 @@ - (void)setPrefersStatusBarHidden:(BOOL)value
>     [self _updateWebViewFullscreenInsets];
> }
> 
>+@synthesize prefersHomeIndicatorAutoHidden=_prefersHomeIndicatorAutoHidden;
>+
>+- (void)setPrefersHomeIndicatorAutoHidden:(BOOL)value
>+{
>+    _prefersHomeIndicatorAutoHidden = value;
>+    [self setNeedsUpdateOfHomeIndicatorAutoHidden];
>+}
>+
> - (void)setPlaying:(BOOL)isPlaying
> {
>     if (_playing == isPlaying)

Actions: View | Formatted Diff | Diff

Attachments on bug 186942: 343365 | 343373