WebKit Bugzilla
Attachment 343355 Details for
Bug 186936
: [Cocoa] REGRESSION(W3C): actions for key equivalents are not respected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186936-20180622124402.patch (text/plain), 1.95 KB, created by
BJ Burg
on 2018-06-22 12:44:03 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
BJ Burg
Created:
2018-06-22 12:44:03 PDT
Size:
1.95 KB
patch
obsolete
>Subversion Revision: 233066 >diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog >index e04913beb2e71d3f999e97b4bcddb6bb05d66052..956768ff76fb75a900e8bab42b371fc26c4462d3 100644 >--- a/Source/WebKit/ChangeLog >+++ b/Source/WebKit/ChangeLog >@@ -1,3 +1,17 @@ >+2018-06-22 Brian Burg <bburg@apple.com> >+ >+ [Cocoa] REGRESSION(W3C): actions for key equivalents are not respected >+ https://bugs.webkit.org/show_bug.cgi?id=186936 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * UIProcess/Automation/WebAutomationSession.cpp: >+ (WebKit::WebAutomationSession::isSimulatingUserInteraction const): >+ This erroneously reported false unless there was both a mouse and key interaction >+ being dispatched, which is not possible in the current serial event simulation model. >+ As a result, Safari could not tell whether the action came from a simulated event >+ or the user, and thus rejected all key equivalents like Cmd-A,V,C,X. >+ > 2018-06-21 Brian Burg <bburg@apple.com> > > Web Automation: key actions should support multiple pressed virtual keys >diff --git a/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp b/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp >index 9f9fc1a14728c186ef89e2f8893bacb7b9dda979..62a223660352c8d1e4d5573712df71531813803e 100644 >--- a/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp >+++ b/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp >@@ -1411,11 +1411,11 @@ bool WebAutomationSession::shouldAllowGetUserMediaForPage(const WebPageProxy&) c > bool WebAutomationSession::isSimulatingUserInteraction() const > { > if (!m_pendingMouseEventsFlushedCallbacksPerPage.isEmpty()) >- return false; >+ return true; > if (!m_pendingKeyboardEventsFlushedCallbacksPerPage.isEmpty()) >- return false; >+ return true; > >- return true; >+ return false; > } > > SimulatedInputDispatcher& WebAutomationSession::inputDispatcherForPage(WebPageProxy& page)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186936
: 343355