Attachment 343341 Details for Bug 186927 – Patch

[patch] Patch

bug-186927-20180622103418.patch (text/plain), 2.68 KB, created by Ross Kirsling on 2018-06-22 10:34:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-06-22 10:34:19 PDT

Size: 2.68 KB

patch

obsolete

>Subversion Revision: 233081
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 45220a2bf3a66b39e3f3e1d25cdabd8c54ee9317..3cdd54104b3f5f7b3bc68241527571959e0a82aa 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-22  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        [Win] ImageDiff should use DLLLauncher
>+        https://bugs.webkit.org/show_bug.cgi?id=186927
>+
>+        ImageDiff should use DLLLauncher to find DLLs under WEBKIT_LIBRARIES, in the same way as DRT & TestWebKitAPI.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * ImageDiff/CMakeLists.txt:
>+        * ImageDiff/ImageDiff.cpp:
>+        (dllLauncherEntryPoint):
>+        * ImageDiff/PlatformWin.cmake:
>+
> 2018-06-20  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
>diff --git a/Tools/ImageDiff/CMakeLists.txt b/Tools/ImageDiff/CMakeLists.txt
>index 2c1ec8ead27129a328240c5aee526b6faf11685d..9c58cc555135a2147926de88e3797dfb6dd709fd 100644
>--- a/Tools/ImageDiff/CMakeLists.txt
>+++ b/Tools/ImageDiff/CMakeLists.txt
>@@ -17,3 +17,7 @@ include_directories(${IMAGE_DIFF_INCLUDE_DIRECTORIES})
> include_directories(SYSTEM ${IMAGE_DIFF_SYSTEM_INCLUDE_DIRECTORIES})
> add_executable(ImageDiff ${IMAGE_DIFF_SOURCES})
> target_link_libraries(ImageDiff ${IMAGE_DIFF_LIBRARIES})
>+
>+if (WIN32)
>+    add_dependencies(ImageDiff ImageDiffLib)
>+endif ()
>diff --git a/Tools/ImageDiff/ImageDiff.cpp b/Tools/ImageDiff/ImageDiff.cpp
>index f8a983b83905cb622f48010e262e574980a2ca74..9849f6fd5d0b0be42cd46c2d9b79e7bcb7d841b5 100644
>--- a/Tools/ImageDiff/ImageDiff.cpp
>+++ b/Tools/ImageDiff/ImageDiff.cpp
>@@ -37,6 +37,7 @@
> #ifdef _WIN32
> #include <fcntl.h>
> #include <io.h>
>+#include <windows.h>
> #endif
> 
> using namespace ImageDiff;
>@@ -136,3 +137,10 @@ int main(int argc, const char* argv[])
> 
>     return EXIT_SUCCESS;
> }
>+
>+#ifdef _WIN32
>+extern "C" __declspec(dllexport) int WINAPI dllLauncherEntryPoint(int argc, const char* argv[])
>+{
>+    return main(argc, argv);
>+}
>+#endif
>diff --git a/Tools/ImageDiff/PlatformWin.cmake b/Tools/ImageDiff/PlatformWin.cmake
>index 2b9a86040fe0e151f2a5b6c8092c8e562359ff0f..08d49f7596a8580a0d499ab6f32f91cddd3ae907 100644
>--- a/Tools/ImageDiff/PlatformWin.cmake
>+++ b/Tools/ImageDiff/PlatformWin.cmake
>@@ -1,5 +1,15 @@
> if (${WTF_PLATFORM_WIN_CAIRO})
>+    add_definitions(-DWIN_CAIRO)
>+
>     include(Cairo.cmake)
> else ()
>     include(PlatformMac.cmake)
> endif ()
>+
>+add_library(ImageDiffLib SHARED ${IMAGE_DIFF_SOURCES})
>+target_link_libraries(ImageDiffLib ${IMAGE_DIFF_LIBRARIES})
>+
>+add_definitions(-DUSE_CONSOLE_ENTRY_POINT)
>+
>+set(IMAGE_DIFF_SOURCES ${TOOLS_DIR}/win/DLLLauncher/DLLLauncherMain.cpp)
>+set(IMAGE_DIFF_LIBRARIES shlwapi)

Actions: View | Formatted Diff | Diff

Attachments on bug 186927: 343334 | 343341