Attachment 343332 Details for Bug 186926 – Proposed patch

[patch] Proposed patch

build_webkit_kls.patch (text/plain), 1.81 KB, created by Aakash Jain on 2018-06-22 09:39:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-06-22 09:39:55 PDT

Size: 1.81 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 233080)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-06-22  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [build.webkit.org] Rename badly named variable kls to schedulerType
>+        https://bugs.webkit.org/show_bug.cgi?id=186926
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
>+        (loadBuilderConfig): Renamed kls to schedulerType.
>+
> 2018-06-20  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
>Index: Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py
>===================================================================
>--- Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	(revision 233080)
>+++ Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	(working copy)
>@@ -57,13 +57,13 @@ def loadBuilderConfig(c, test_mode_is_en
>     for scheduler in config['schedulers']:
>         if "change_filter" in scheduler:
>             scheduler["change_filter"] = globals()[scheduler["change_filter"]]
>-        kls = globals()[scheduler.pop('type')]
>+        schedulerType = globals()[scheduler.pop('type')]
>         # Python 2.6 can't handle unicode keys as keyword arguments:
>         # http://bugs.python.org/issue2646.  Modern versions of json return
>         # unicode strings from json.load, so we map all keys to str objects.
>         scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items()))
> 
>-        c['schedulers'].append(kls(**scheduler))
>+        c['schedulers'].append(schedulerType(**scheduler))
> 
>     forceScheduler = ForceScheduler(
>         name="force",

Actions: View | Formatted Diff | Diff

Attachments on bug 186926: 343332 | 343444