WebKit Bugzilla
Attachment 343326 Details for
Bug 186921
: [GStreamer] Remove useless workaround
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186921-20180622162846.patch (text/plain), 1.89 KB, created by
Philippe Normand
on 2018-06-22 08:28:47 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Philippe Normand
Created:
2018-06-22 08:28:47 PDT
Size:
1.89 KB
patch
obsolete
>Subversion Revision: 233073 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 56f26de3cb463a463c1327b6749b5edbc66b7c07..44d311adfec3f2cdb026fea47fb95ca42bc8b276 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,18 @@ >+2018-06-22 Philippe Normand <pnormand@igalia.com> >+ >+ [GStreamer] Remove useless workaround >+ https://bugs.webkit.org/show_bug.cgi?id=186921 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ In bug 67407 a workaround was added for GStreamer 0.10. With 1.x >+ the media/video-reverse-play-duration.html test passes without any >+ workaround needed. The other test mentioned in that bug was >+ removed, it seems. >+ >+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: >+ (WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const): >+ > 2018-06-15 Jer Noble <jer.noble@apple.com> > > Address fullscreen api CSS env feedback >diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp >index ebc0472d6ef54b6c39642cb2acd241f056366ef1..3383dbe537d6dd5a8c39d35db64f667458c746da 100644 >--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp >+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp >@@ -487,14 +487,6 @@ MediaTime MediaPlayerPrivateGStreamer::currentMediaTime() const > if (m_seeking) > return m_seekTime; > >- // Workaround for >- // https://bugzilla.gnome.org/show_bug.cgi?id=639941 In GStreamer >- // 0.10.35 basesink reports wrong duration in case of EOS and >- // negative playback rate. There's no upstream accepted patch for >- // this bug yet, hence this temporary workaround. >- if (m_isEndReached && m_playbackRate < 0) >- return MediaTime::invalidTime(); >- > return playbackPosition(); > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186921
:
343326
|
343349
|
343458
|
344421