Attachment 343312 Details for Bug 186911 – Patch

[patch] Patch

wcore-css-generated.diff (text/plain), 2.73 KB, created by Carlos Garcia Campos on 2018-06-22 00:42:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-06-22 00:42:03 PDT

Size: 2.73 KB

patch

obsolete

>diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
>index b02858cb478..a3a19ce56be 100644
>--- a/Source/WebCore/CMakeLists.txt
>+++ b/Source/WebCore/CMakeLists.txt
>@@ -1740,14 +1740,16 @@ ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/css/CSSPrimitiveValueMapp
> # Generate CSS Selector pseudo type name to value maps.
> add_custom_command(
>     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp
>-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in
>+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
>     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
>     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoClassAndCompatibilityElementMap.py ${WEBCORE_DIR}/css/SelectorPseudoClassAndCompatibilityElementMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
>     VERBATIM)
> list(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoClassAndCompatibilityElementMap.cpp)
> add_custom_command(
>     OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.gperf ${DERIVED_SOURCES_WEBCORE_DIR}/SelectorPseudoElementTypeMap.cpp
>-    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
>+    MAIN_DEPENDENCY ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in
>+    DEPENDS ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py
>     WORKING_DIRECTORY ${DERIVED_SOURCES_WEBCORE_DIR}
>     COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/css/makeSelectorPseudoElementsMap.py ${WEBCORE_DIR}/css/SelectorPseudoElementTypeMap.in "${GPERF_EXECUTABLE}" "${FEATURE_DEFINES_WITH_SPACE_SEPARATOR}"
>     VERBATIM)
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 56f26de3cb4..3c0234ffe21 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
>+        https://bugs.webkit.org/show_bug.cgi?id=186911
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
>+        didn't start a clean build. The problem is that the CMake command to generate
>+        SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
>+        SelectorPseudoClassAndCompatibilityElementMap.in.
>+
>+        * CMakeLists.txt:
>+
> 2018-06-15  Jer Noble  <jer.noble@apple.com>
> 
>         Address fullscreen api CSS env feedback

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186911: 343312 | 343314