Attachment 343286 Details for Bug 186900 – Patch

[patch] Patch

bug-186900-20180621161919.patch (text/plain), 1.66 KB, created by Megan Gardner on 2018-06-21 16:19:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-06-21 16:19:20 PDT

Size: 1.66 KB

patch

obsolete

>Subversion Revision: 233064
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 05aa2ff1519d440bb2bbc3af5f1e0d6ce90a5161..a23e83e844e6419b0960f9075c7ff98bd4a7e1f3 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-21  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Fix iBeam issues with iPad apps on Mac
>+        https://bugs.webkit.org/show_bug.cgi?id=186900
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        UIKit is using this function to determine if we should show an iBeam or not.
>+        So we need to implement it, at least for this platform. 
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView closestPositionToPoint:]):
>+
> 2018-06-21  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r232884.
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index 266926d0b0009658f2c6c21a5739aef530dae6a8..488610a912d9bec4f7802a55ee0ba1248741b0df 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -3319,6 +3319,14 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
> /* Hit testing. */
> - (UITextPosition *)closestPositionToPoint:(CGPoint)point
> {
>+#if ENABLE(MINIMAL_SIMULATOR)
>+    InteractionInformationRequest request(roundedIntPoint(point));
>+    if (![self ensurePositionInformationIsUpToDate:request])
>+        return nil;
>+
>+    if (_positionInformation.isSelectable)
>+        return [WKTextPosition textPositionWithRect:_positionInformation.bounds];
>+#endif
>     return nil;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186900: 343283 | 343286 | 343294 | 343434 | 343564 | 343570 | 343607 | 343643 | 343665 | 343770