Attachment 343272 Details for Bug 186895 – Patch

[patch] Patch

bug-186895-20180621135155.patch (text/plain), 1.62 KB, created by Per Arne Vollan on 2018-06-21 13:51:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-06-21 13:51:55 PDT

Size: 1.62 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 233055)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-06-21  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Delete display link when closing page or the WebContent process has crashed.
>+        https://bugs.webkit.org/show_bug.cgi?id=186895
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If there is a running display link in the UI process, there is no need to keep it around if the
>+        page is being closed or the WebContent process has crashed.
>+
>+        * UIProcess/WebPageProxy.cpp:
>+        (WebKit::WebPageProxy::close):
>+        (WebKit::WebPageProxy::resetStateAfterProcessExited):
>+
> 2018-06-21  Jer Noble  <jer.noble@apple.com>
> 
>         [Fullscreen] Use secondary glyph style for fullscreen controls
>Index: Source/WebKit/UIProcess/WebPageProxy.cpp
>===================================================================
>--- Source/WebKit/UIProcess/WebPageProxy.cpp	(revision 233041)
>+++ Source/WebKit/UIProcess/WebPageProxy.cpp	(working copy)
>@@ -920,6 +920,10 @@ void WebPageProxy::close()
>     m_activityToken = nullptr;
> #endif
> 
>+#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
>+    m_displayLink = nullptr;
>+#endif
>+
>     stopAllURLSchemeTasks();
> }
> 
>@@ -6085,6 +6089,11 @@ void WebPageProxy::resetStateAfterProces
> #if PLATFORM(IOS)
>     m_activityToken = nullptr;
> #endif
>+
>+#if PLATFORM(MAC) && ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
>+    m_displayLink = nullptr;
>+#endif
>+
>     m_pageIsUserObservableCount = nullptr;
>     m_visiblePageToken = nullptr;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186895: 343272 | 343302 | 343423