Attachment 343227 Details for Bug 186880 – Patch

[patch] Patch

bug-186880-20180621022005.patch (text/plain), 5.25 KB, created by Fujii Hironori on 2018-06-21 02:20:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-06-21 02:20:13 PDT

Size: 5.25 KB

patch

obsolete

>Subversion Revision: 233029
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 6b71bfb2a8b40c967830b01885d1f2a5a7b51ad8..41dfbc1c9a1b1e07269f9759357435b11b407ccc 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,26 @@
>+2018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
>+        https://bugs.webkit.org/show_bug.cgi?id=186880
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Bug 180253 has added assertions the arugments `start` and `end` is
>+        valid MediaTime in PlatformTimeRanges::add. Since then, some
>+        LayoutTests fail due to the assertion failure.
>+
>+        The invalid MediaTime is added into the PlatformTimeRanges in
>+        MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
>+        original implementation checks MediaTime::operator bool() returns
>+        true. But, this method returns true if the time value is invalid.
>+        Then, PlatformTimeRanges::add is called with an invalid MediaTime.
>+
>+        No new tests (No behavior change).
>+
>+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
>+        (WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
>+        maxTimeLoaded() is valid before adding to `timeRanges`.
>+
> 2018-06-20  David Kilzer  <ddkilzer@apple.com>
> 
>         Fix leaks in WebCore found by clang static analyzer in deep mode
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index 9a0711e73dda006805543318e3970a445a03e4ba..ebc0472d6ef54b6c39642cb2acd241f056366ef1 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -1112,7 +1112,8 @@ std::unique_ptr<PlatformTimeRanges> MediaPlayerPrivateGStreamer::buffered() cons
>     // Fallback to the more general maxTimeLoaded() if no range has
>     // been found.
>     if (!timeRanges->length()) {
>-        if (MediaTime loaded = maxTimeLoaded())
>+        MediaTime loaded = maxTimeLoaded();
>+        if (loaded.isValid() && loaded)
>             timeRanges->add(MediaTime::zeroTime(), loaded);
>     }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d2d683403408196df77ab5d47c542d83db640b8e..a1d6f2619dd6d785232c583c379d741229d1b05b 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
>+        https://bugs.webkit.org/show_bug.cgi?id=186880
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/gtk/TestExpectations: Removed Crash marks of
>+        compositing/geometry/clipped-video-controller.html,
>+        fast/canvas/webgl/oes-texture-half-float-with-video.html,
>+        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html,
>+        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html,
>+        fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html,
>+        fast/events/media-focus-in-standalone-media-document.html,
>+        fullscreen/video-controls-timeline.html,
>+        http/tests/appcache/video.html, and compositing/video/poster.html.
>+
> 2018-06-20  Per Arne Vollan  <pvollan@apple.com>
> 
>         Layout Test imported/mozilla/css-animations/test_pseudoElement-get-animations.html is failing.
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 033760340258a9bec9dafd6fab036fd643984f82..e0799d7223bbb15b0e456087f4db101796cd503a 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1284,15 +1284,6 @@ webkit.org/b/185546 media/video-playbackrate.html [ Crash Pass ]
> 
> webkit.org/b/185910 media/video-duration-known-after-eos.html [ Crash Pass ]
> 
>-webkit.org/b/180253 [ Debug ] compositing/geometry/clipped-video-controller.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fast/canvas/webgl/oes-texture-half-float-with-video.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fast/events/media-focus-in-standalone-media-document.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] fullscreen/video-controls-timeline.html [ Crash ]
>-webkit.org/b/180253 [ Debug ] http/tests/appcache/video.html [ Crash ]
>-
> # Crashes only when GNOME icon theme is not installed
> webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
> 
>@@ -1931,8 +1922,7 @@ webkit.org/b/183608 imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapK
> 
> webkit.org/b/183609 inspector/unit-tests/throttle.html [ Pass Failure ]
> 
>-# Crash is bug #180253
>-webkit.org/b/183214 compositing/video/poster.html [ Pass ImageOnlyFailure Crash ]
>+webkit.org/b/183214 compositing/video/poster.html [ Pass ImageOnlyFailure ]
> 
> webkit.org/b/183903 http/tests/media/video-buffered-range-contains-currentTime.html [ Crash Pass ]
>

Flags:

calvaris: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186880: 343227