Attachment 343210 Details for Bug 186876 – Proposed patch

[patch] Proposed patch

ews_forcescheduler.patch (text/plain), 1.76 KB, created by Aakash Jain on 2018-06-20 21:11:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-06-20 21:11:42 PDT

Size: 1.76 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 233029)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-06-20  Aakash Jain  <aakash_jain@apple.com>
>+
>+        Add force schedulers to OpenSource EWS Buildbot
>+        https://bugs.webkit.org/show_bug.cgi?id=186876
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/loadConfig.py:
>+        (loadBuilderConfig): Added support for ForceScheduler.
>+
> 2018-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [WebKit on watchOS] Fixed position elements sometimes flicker when scrolling
>Index: Tools/BuildSlaveSupport/ews-build/loadConfig.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/loadConfig.py	(revision 233029)
>+++ Tools/BuildSlaveSupport/ews-build/loadConfig.py	(working copy)
>@@ -25,6 +25,7 @@ import json
> import re
> 
> from buildbot.scheduler import AnyBranchScheduler, Periodic, Dependent, Triggerable, Nightly
>+from buildbot.schedulers.forcesched import ForceScheduler, WorkerChoiceParameter
> from buildbot.worker import Worker
> from buildbot.util import identifiers as buildbot_identifiers
> 
>@@ -59,6 +60,11 @@ def loadBuilderConfig(c):
>         scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items()))
>         c['schedulers'].append(schedulerType(**scheduler))
> 
>+        force_scheduler = ForceScheduler(name='force-{0}'.format(scheduler['name']),
>+                                         builderNames=scheduler['builderNames'],
>+                                         properties=[WorkerChoiceParameter()])
>+        c['schedulers'].append(force_scheduler)
>+
> 
> def checkValidWorker(worker):
>     if not worker:

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186876: 343210