Attachment 343206 Details for Bug 182352 – Patch

[patch] Patch

bug-182352-20180620200738.patch (text/plain), 4.44 KB, created by Fujii Hironori on 2018-06-20 20:07:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-06-20 20:07:53 PDT

Size: 4.44 KB

patch

obsolete

>Subversion Revision: 233001
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 74119bb35a3e3a958c84e7635300330e49d65bbf..c22b449993f70e574a7174725df975265fe853f1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,31 @@
>+2018-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [GTK] http/tests/misc/bubble-drag-events.html crashes
>+        https://bugs.webkit.org/show_bug.cgi?id=182352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        PingLoad::didFinish was called twice if it is used with
>+        NetworkDataTaskSoup. PingLoad is not a ref-counted object. It is
>+        destructed when PingLoad::didFinish is called.
>+
>+        PingLoad::didReceiveChallenge calls the ChallengeCompletionHandler
>+        with AuthenticationChallengeDisposition::Cancel to cancel the
>+        challenge and calls PingLoad::didFinish.
>+
>+        NetworkDataTaskSoup::continueAuthenticate calls
>+        didReceiveChallenge with a ChallengeCompletionHandler which calls
>+        didCompleteWithError. PingLoad::didCompleteWithError calls
>+        PingLoad::didFinish.
>+
>+        didCompleteWithError callback should not be called in the
>+        ChallengeCompletionHandler.
>+
>+        * NetworkProcess/soup/NetworkDataTaskSoup.cpp:
>+        (WebKit::NetworkDataTaskSoup::continueAuthenticate): Do not call
>+        didFail() in the ChallengeCompletionHandler. Call
>+        invalidateAndCancel() instead.
>+
> 2018-06-19  Dean Jackson  <dino@apple.com>
> 
>         Blank viewer comes up and then auto-dismisses when device is not connected to Internet
>diff --git a/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp b/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
>index 348181ca8914e472bad9c16bd95e898634673d31..60d1621c1a3239805331ec750b5e5b23fb3cf136 100644
>--- a/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
>+++ b/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
>@@ -528,8 +528,7 @@ void NetworkDataTaskSoup::continueAuthenticate(AuthenticationChallenge&& challen
>         }
> 
>         if (disposition == AuthenticationChallengeDisposition::Cancel) {
>-            cancel();
>-            didFail(cancelledError(m_soupRequest.get()));
>+            invalidateAndCancel();
>             return;
>         }
> 
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5e064113bb7bf6b97da9162e70f1d8fa789f61e5..63b8a2c722cfe9e0080e08a62fe7fada4b02162e 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        [GTK] http/tests/misc/bubble-drag-events.html crashes
>+        https://bugs.webkit.org/show_bug.cgi?id=182352
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/gtk/TestExpectations:
>+        Marked http/tests/misc/bubble-drag-events.html as [ Failure ] not
>+        [ Failure Timeout Crash ].
>+        Unmarked http/tests/misc/cached-scripts.html.
>+
> 2018-06-19  Per Arne Vollan  <pvollan@apple.com>
> 
>         Layout Test imported/mozilla/css-animations/test_animation-playstate.html is failing.
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 65ef419f2418c115d1bf805cfd7b183853a7d95d..5c439cc99876dac0af7e02e10937b1f4f3c00a12 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -1296,9 +1296,6 @@ webkit.org/b/180253 [ Debug ] http/tests/appcache/video.html [ Crash ]
> # Crashes only when GNOME icon theme is not installed
> webkit.org/b/186767 fast/hidpi/broken-image-icon-very-hidpi.html [ Crash Pass ]
> 
>-# This one crashes only on EWS.
>-webkit.org/b/186778 http/tests/misc/cached-scripts.html [ Crash Pass ]
>-
> webkit.org/b/186779 http/tests/security/sandboxed-iframe-DENIED-modals.html [ Crash Pass ]
> 
> #////////////////////////////////////////////////////////////////////////////////////////
>@@ -2656,7 +2653,7 @@ Bug(GTK) canvas/philip/tests/2d.text.measure.width.space.html [ Failure ]
> Bug(GTK) http/tests/local/drag-over-remote-content.html [ Failure ]
> Bug(GTK) http/tests/security/drag-over-remote-content-iframe.html [ Failure ]
> Bug(GTK) fast/events/drag-in-frames.html [ Failure Timeout ]
>-webkit.org/b/182352 http/tests/misc/bubble-drag-events.html [ Failure Timeout Crash ]
>+webkit.org/b/182352 http/tests/misc/bubble-drag-events.html [ Failure ]
> 
> # Dragging images and links results in a DataTransfer object containing a non-empty files array
> webkit.org/b/52094 editing/pasteboard/files-during-page-drags.html [ Failure ]

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 182352: 343132 | 343135 | 343141 | 343144 | 343206 | 344406 | 344408 | 344411 | 344414 | 344416 | 344419 | 344568 | 344929 | 345033