WebKit Bugzilla
Attachment 343192 Details for
Bug 186867
: Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186867-20180620165845.patch (text/plain), 2.38 KB, created by
Daniel Bates
on 2018-06-20 16:58:46 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Daniel Bates
Created:
2018-06-20 16:58:46 PDT
Size:
2.38 KB
patch
obsolete
>Subversion Revision: 232965 >diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog >index 4875c64c3c485ade350f6c083d83faf74b4f7706..e2fe8bb4000e8f28e68d58c37ad00aec95f81334 100644 >--- a/Source/WebInspectorUI/ChangeLog >+++ b/Source/WebInspectorUI/ChangeLog >@@ -1,3 +1,20 @@ >+2018-06-20 Daniel Bates <dabates@apple.com> >+ >+ Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab >+ https://bugs.webkit.org/show_bug.cgi?id=186867 >+ <rdar://problem/41175424> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Fixes an issue where cookies that do not have a Same-Site policy would be marked up as Same- >+ Site Strict in Web Inspector's cookie storage content view (under the storage tab). >+ >+ * UserInterface/Views/CookieStorageContentView.js: >+ (WI.CookieStorageContentView.prototype._rebuildTable): Only compute the display name if >+ we cookie.sameSite is non-null and is not WI.Cookie.SameSiteType.None. Moreover, remove >+ an extraneous call to WI.Cookie.parseSameSiteAttributeValue() as cookie.SameSite represents >+ the already parsed value (one of the WI.Cookie.SameSiteType-scoped values). >+ > 2018-06-18 Brian Burg <bburg@apple.com> > > Web Inspector: TypeError: Array.prototype.sort passed bad value in NetworkTableContentView _updateSortAndFilteredEntries >diff --git a/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js b/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js >index 8bec9a9e151f640561767ff0d445dd80e5df8991..e05cb97d6e99a0800ed23fc48465867dc7608513 100644 >--- a/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js >+++ b/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js >@@ -140,7 +140,7 @@ WI.CookieStorageContentView = class CookieStorageContentView extends WI.ContentV > size: Number.bytesToString(cookie.size), > http: cookie.httpOnly ? checkmark : "", > secure: cookie.secure ? checkmark : "", >- sameSite: cookie.sameSite ? WI.Cookie.displayNameForSameSiteType(WI.Cookie.parseSameSiteAttributeValue(cookie.sameSite)) : "", >+ sameSite: !cookie.sameSite || cookie.sameSite === WI.Cookie.SameSiteType.None ? "" : WI.Cookie.displayNameForSameSiteType(cookie.sameSite), > }; > > if (cookie.type !== WI.CookieType.Request)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mattbaker
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186867
: 343192