Attachment 343175 Details for Bug 186858 – Patch

[patch] Patch

bug-186858-20180620152027.patch (text/plain), 2.35 KB, created by Leo Balter on 2018-06-20 12:20:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-06-20 12:20:27 PDT

Size: 2.35 KB

patch

obsolete

>Subversion Revision: 233017
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 4e46d5b800273bed2acbc296f22fd44966a4d399..07097c6fe96d685c56600b2e61601572b2cb8b78 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-20  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        [test262-runner] Improve failures output
>+        https://bugs.webkit.org/show_bug.cgi?id=186858
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (main):
>+        (processResult):
>+
> 2018-06-20  Robin Morisset  <rmorisset@apple.com>
> 
>         [WSL] Add details to the sphinx outline
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index b4a768baded1363d554e29248a1ad1a0f37865dd..df69a2552452fb2afd02e2e2f9bb814b79374c63 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -458,8 +458,11 @@ sub main {
>                 if ($verbose) {
>                     my $path = $test->{path};
>                     my $mode = $test->{mode};
>-                    my $err = $test->{error};
>-                    $newfailurereport .= "FAIL $path ($mode)\n$err\n\n";
>+                    # Print full output from JSC
>+                    my $err = $test->{output};
>+                    $newfailurereport .= "FAIL $path ($mode)\n"
>+                        . "Full Output:\n"
>+                        . "$err\n\n";
>                 }
>             }
> 
>@@ -819,18 +822,17 @@ sub processResult {
>         my $failMsg = '';
>         $failMsg = "FAIL $file ($scenario)\n";
> 
>-        my $suffixMsg = '';
>+        my $featuresList = '';
> 
>-        if ($verbose) {
>-            my $featuresList = '';
>-            $featuresList = "\nFeatures: " . join(', ', @{ $data->{features} }) if $data->{features};
>-            $suffixMsg = "$result$featuresList\n";
>+        if ($verbose && $data->{features}) {
>+            $featuresList = 'Features: ' . join(', ', @{ $data->{features} }) . "\n";
>         }
> 
>-        print "$newFail$failMsg$suffixMsg" if ($printFailure || $verbose);
>+        print "$newFail$failMsg$featuresList$result\n\n" if ($printFailure || $verbose);
> 
>         $resultdata{result} = 'FAIL';
>         $resultdata{error} = $currentfailure;
>+        $resultdata{output} = $result;
>     } elsif ($scenario ne 'skip' && !$currentfailure) {
>         if ($expectedfailure) {
>             print "NEW PASS $file ($scenario)\n";

Actions: View | Formatted Diff | Diff

Attachments on bug 186858: 343175 | 343215