Attachment 343160 Details for Bug 186850 – Patch

[patch] Patch

bug-186850-20180620085201.patch (text/plain), 1.81 KB, created by Chris Dumez on 2018-06-20 08:52:02 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-20 08:52:02 PDT

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 232995
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index b3bfc1c4ff82e189e9acb68ae9e558020827ebb0..5433799b528c88ab51c2edea5a218c22bdfaba2e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-20  Chris Dumez  <cdumez@apple.com>
>+
>+        Regression(r226990) : Crash under WebCore::Page::applicationWillResignActive
>+        https://bugs.webkit.org/show_bug.cgi?id=186850
>+        <rdar://problem/37394469>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure m_page is not null before calling applicationWillResignActive(). m_page
>+        gets nulled out when WebPage::close() is called. The crash trace seems to indicate
>+        we're calling applicationWillResignActive() on a Page that is dead since we crash
>+        accessing Page::mainFrame().
>+
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::applicationWillResignActive):
>+
> 2018-06-19  Chris Dumez  <cdumez@apple.com>
> 
>         Implement IPC throttling to keep the main thread responsive when a process misbehaves
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index bc297a2f6086a141e81eb91fefbb0bd6ec6f6a9a..8fa8733d0e3e33647eb79347d6e17bfe6b90aec7 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -2760,7 +2760,8 @@ void WebPage::updateViewportSizeForCSSViewportUnits()
> void WebPage::applicationWillResignActive()
> {
>     [[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillResignActiveNotification object:nil];
>-    m_page->applicationWillResignActive();
>+    if (m_page)
>+        m_page->applicationWillResignActive();
> }
> 
> void WebPage::applicationDidEnterBackground(bool isSuspendedUnderLock)

Actions: View | Formatted Diff | Diff

Attachments on bug 186850: 343160 | 343170