Attachment 343146 Details for Bug 186840 – Patch

[patch] Patch

bug-186840-20180620121455.patch (text/plain), 1.51 KB, created by Miguel Gomez on 2018-06-20 03:14:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Miguel Gomez

Created: 2018-06-20 03:14:56 PDT

Size: 1.51 KB

patch

obsolete

>Subversion Revision: 233006
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8d2bd52a62fba7dfa10e5688cb9a68e4ae5bf862..77043ee444d4f879781098c7af891ff2638778da 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-20  Miguel Gomez  <magomez@igalia.com>
>+
>+        [GTK][ThreadedRendering][Nicosia] Themed elements cannot be rendered using threaded rendering
>+        https://bugs.webkit.org/show_bug.cgi?id=186840
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Disable threaded rendering for GTK port.
>+
>+        * platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
>+        (Nicosia::PaintingEngine::create):
>+
> 2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
>diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>index 3bd9bf3237091e8c7697878a992ec65b0f97565b..07ae7a263c05e8dd30ed95534676eae857e40c14 100644
>--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>@@ -36,7 +36,7 @@ namespace Nicosia {
> 
> std::unique_ptr<PaintingEngine> PaintingEngine::create()
> {
>-#if ENABLE(DEVELOPER_MODE)
>+#if ENABLE(DEVELOPER_MODE) && PLATFORM(WPE)
>     if (const char* numThreadsEnv = getenv("WEBKIT_NICOSIA_PAINTING_THREADS")) {
>         unsigned numThreads = 0;
>         if (sscanf(numThreadsEnv, "%u", &numThreads) == 1) {

Actions: View | Formatted Diff | Diff

Attachments on bug 186840: 343143 | 343146