Attachment 343143 Details for Bug 186840 – Patch

[patch] Patch

bug-186840-20180620110259.patch (text/plain), 2.09 KB, created by Miguel Gomez on 2018-06-20 02:03:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Miguel Gomez

Created: 2018-06-20 02:03:01 PDT

Size: 2.09 KB

patch

obsolete

>Subversion Revision: 233005
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 18ba9250868b506c551cbfb5e09349d1602ab1de..84edda08e54adfd13e01067bc35f1cea7d71096b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-20  Miguel Gomez  <magomez@igalia.com>
>+
>+        [GTK][ThreadedRendering] Do not try to render scrollbars if the GraphicsContext doesn't have a PlatformContext
>+        https://bugs.webkit.org/show_bug.cgi?id=186840
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Do not try to render the scrollbars if the GraphicsContext used doesn't have a PlatformContext.
>+
>+        No new tests.
>+
>+        * platform/gtk/ScrollbarThemeGtk.cpp:
>+        (WebCore::ScrollbarThemeGtk::paint):
>+
> 2018-06-19  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably
>diff --git a/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp b/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
>index 8466aacdf74529df73213e730b386280a1e636fd..ad0b2ade5417ad2e0495c62900dfb7137bdddbe4 100644
>--- a/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
>+++ b/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
>@@ -449,7 +449,7 @@ IntRect ScrollbarThemeGtk::forwardButtonRect(Scrollbar& scrollbar, ScrollbarPart
> #if GTK_CHECK_VERSION(3, 20, 0)
> bool ScrollbarThemeGtk::paint(Scrollbar& scrollbar, GraphicsContext& graphicsContext, const IntRect& damageRect)
> {
>-    if (graphicsContext.paintingDisabled())
>+    if (graphicsContext.paintingDisabled() || !graphicsContext.platformContext())
>         return false;
> 
>     if (!scrollbar.enabled())
>@@ -662,7 +662,7 @@ static void adjustRectAccordingToMargin(GtkStyleContext* context, IntRect& rect)
> 
> bool ScrollbarThemeGtk::paint(Scrollbar& scrollbar, GraphicsContext& graphicsContext, const IntRect& damageRect)
> {
>-    if (graphicsContext.paintingDisabled())
>+    if (graphicsContext.paintingDisabled() || !graphicsContext.platformContext())
>         return false;
> 
>     GRefPtr<GtkStyleContext> styleContext = createStyleContext(&scrollbar);

Actions: View | Formatted Diff | Diff

Attachments on bug 186840: 343143 | 343146