Attachment 343142 Details for Bug 186838 – Patch

[patch] Patch

bug-186838-20180620103811.patch (text/plain), 1.56 KB, created by Rob Buis on 2018-06-20 01:38:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2018-06-20 01:38:13 PDT

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 233005
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 0aedfb7b849e2eddb846552559d32c52753862a0..5d1dfbb3ef1bbab59681de63f4a8f434843140f3 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-20  Rob Buis  <rbuis@igalia.com>
>+
>+        [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
>+        https://bugs.webkit.org/show_bug.cgi?id=186838
>+
>+        This URL constructor expects canonicalized input, so fix the passed URL.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
> 
>         [WPE] Remove warnings by setting nullptr for unused listeners
>diff --git a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>index 057905b139a59ef37e356964c040aa5e7dc12746..55732cfaf6303dc6ee41a51fd520149a42135069 100644
>--- a/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
>@@ -80,7 +80,7 @@ TEST(UserAgentTest, Quirks)
> 
>     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.com/");
>     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
>-    assertUserAgentForURLHasChromeBrowserQuirk("http://www.washingtonpost.com");
>+    assertUserAgentForURLHasChromeBrowserQuirk("http://www.washingtonpost.com/");
> 
>     assertUserAgentForURLHasLinuxPlatformQuirk("http://www.google.com/");
>     assertUserAgentForURLHasLinuxPlatformQuirk("http://www.google.es/");

Actions: View | Formatted Diff | Diff

Attachments on bug 186838: 343142 | 344059 | 344063