Attachment 343139 Details for Bug 186836 – Patch

[patch] Patch

bug-186836-20180620165950.patch (text/plain), 6.00 KB, created by Yusuke Suzuki on 2018-06-20 00:59:51 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-06-20 00:59:51 PDT

Size: 6.00 KB

patch

obsolete

>Subversion Revision: 233004
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index a9c791b242b29828d64b8d51d4bd6ac25686008d..40341210c45be49cc5752578583d41a8c2505143 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
>+        https://bugs.webkit.org/show_bug.cgi?id=186836
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        AutomaticThread can take a name for the generated threads now.
>+        This patch adds the above ability to WorkerPool.
>+
>+        * wtf/WorkerPool.cpp:
>+        (WTF::WorkerPool::WorkerPool):
>+        * wtf/WorkerPool.h:
>+        (WTF::WorkerPool::create):
>+        (WTF::WorkerPool::name const):
>+
> 2018-06-18  Jiewen Tan  <jiewen_tan@apple.com>
> 
>         Add a graceful exit for AuthenticationManager::initializeConnection
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 18ba9250868b506c551cbfb5e09349d1602ab1de..c62c43cf5c2de09d433150c644fd9dbde0d57af9 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
>+        https://bugs.webkit.org/show_bug.cgi?id=186836
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use "PaintingThread" name.
>+
>+        * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
>+        (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
>+
> 2018-06-19  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably
>diff --git a/Source/WTF/wtf/WorkerPool.cpp b/Source/WTF/wtf/WorkerPool.cpp
>index 3ccb7a2dee6484af842861da5419467eeda5b003..7b921057f5c650adfdc07eebb33ded0bdd80a150 100644
>--- a/Source/WTF/wtf/WorkerPool.cpp
>+++ b/Source/WTF/wtf/WorkerPool.cpp
>@@ -75,7 +75,7 @@ class WorkerPool::Worker final : public AutomaticThread {
> 
>     const char* name() const override
>     {
>-        return "Worker Pool";
>+        return m_pool.name();
>     }
> 
> private:
>@@ -83,10 +83,11 @@ class WorkerPool::Worker final : public AutomaticThread {
>     Function<void()> m_task;
> };
> 
>-WorkerPool::WorkerPool(unsigned numberOfWorkers, Seconds timeout)
>+WorkerPool::WorkerPool(const char* name, unsigned numberOfWorkers, Seconds timeout)
>     : m_lock(Box<Lock>::create())
>     , m_condition(AutomaticThreadCondition::create())
>     , m_timeout(timeout)
>+    , m_name(name)
> {
>     LockHolder locker(*m_lock);
>     for (unsigned i = 0; i < numberOfWorkers; ++i)
>diff --git a/Source/WTF/wtf/WorkerPool.h b/Source/WTF/wtf/WorkerPool.h
>index b5f4d345dc18a69c302c5984254d0932240e2af3..e48fd791f6b287d6fdae792497d233734656408d 100644
>--- a/Source/WTF/wtf/WorkerPool.h
>+++ b/Source/WTF/wtf/WorkerPool.h
>@@ -40,17 +40,19 @@ class WorkerPool : public ThreadSafeRefCounted<WorkerPool> {
>     WTF_EXPORT_PRIVATE ~WorkerPool();
> 
>     // If timeout is infinity, it means AutomaticThread will be never automatically destroyed.
>-    static Ref<WorkerPool> create(unsigned numberOfWorkers  = WTF::numberOfProcessorCores(), Seconds timeout = Seconds::infinity())
>+    static Ref<WorkerPool> create(const char* name, unsigned numberOfWorkers  = WTF::numberOfProcessorCores(), Seconds timeout = Seconds::infinity())
>     {
>         ASSERT(numberOfWorkers >= 1);
>-        return adoptRef(*new WorkerPool(numberOfWorkers, timeout));
>+        return adoptRef(*new WorkerPool(name, numberOfWorkers, timeout));
>     }
> 
>+    const char* name() const { return m_name; }
>+
> private:
>     class Worker;
>     friend class Worker;
> 
>-    WTF_EXPORT_PRIVATE WorkerPool(unsigned numberOfWorkers, Seconds timeout);
>+    WTF_EXPORT_PRIVATE WorkerPool(const char* name, unsigned numberOfWorkers, Seconds timeout);
> 
>     bool shouldSleep(const AbstractLocker&);
> 
>@@ -61,6 +63,7 @@ class WorkerPool : public ThreadSafeRefCounted<WorkerPool> {
>     unsigned m_numberOfActiveWorkers { 0 };
>     Vector<Ref<Worker>> m_workers;
>     Deque<Function<void()>> m_tasks;
>+    const char* m_name;
> };
> 
> }
>diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>index 609d1c301c3f000b93de17cd9e89074c3a457166..60ffbaa019defd3b3a0411fd981222f105cb6ae5 100644
>--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>@@ -60,7 +60,7 @@ static void paintLayer(GraphicsContext& context, GraphicsLayer& layer, const Int
> }
> 
> PaintingEngineThreaded::PaintingEngineThreaded(unsigned numThreads)
>-    : m_workerPool(WorkerPool::create(numThreads))
>+    : m_workerPool(WorkerPool::create("PaintingThread", numThreads))
> {
> }
> 
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 408f6f2f2cf77375e8a4c25474721287ca356918..72da117852c30e17ea2cb0c554dff3f397928533 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
>+        https://bugs.webkit.org/show_bug.cgi?id=186836
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WTF/WorkerPool.cpp:
>+        (TestWebKitAPI::TEST):
>+
> 2018-06-19  Leo Balter  <leonardo.balter@gmail.com>
> 
>         [test262-runner] Reduce flakiness of unit tests for the runner
>diff --git a/Tools/TestWebKitAPI/Tests/WTF/WorkerPool.cpp b/Tools/TestWebKitAPI/Tests/WTF/WorkerPool.cpp
>index f98e28a1a7a2b1ef2717eac524476045a9e6c6b5..66ecdc0f73ebdc82d11370fc02b416ce9d3fda07 100644
>--- a/Tools/TestWebKitAPI/Tests/WTF/WorkerPool.cpp
>+++ b/Tools/TestWebKitAPI/Tests/WTF/WorkerPool.cpp
>@@ -36,7 +36,7 @@ TEST(WTF, WorkerPoolDecrease)
> {
>     std::atomic<unsigned> counter { 0 };
>     {
>-        Ref<WorkerPool> pool = WorkerPool::create();
>+        Ref<WorkerPool> pool = WorkerPool::create("Worker Pool");
>         for (int i = 0; i < 10000; ++i) {
>             pool->postTask([&] {
>                 ++counter;

Flags:

cgarcia: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186836: 343138 | 343139